FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[Doc] expanded basic pie example by story645 · Pull Request #24812 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

[Doc] expanded basic pie example - #24812

Merged
QuLogic merged 1 commit into
matplotlib:mainfrom
story645:pie-example
Jan 20, 2023
ConversationCommits (1)ChecksFiles changed
Merged

[Doc] expanded basic pie example#24812
QuLogic merged 1 commit into
matplotlib:mainfrom
story645:pie-example

Conversation

story645 commented Dec 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

added small examples of labels, autopct, colors, hatch, and distance in an attempt to scaffold up to exploding example. I also kinda really like this model of documenting the plotting methods - small isolated example of each notable keyword - so if other folks do too, this could be a way to consolidate some of the examples. It's also a style I'm seeing a lot in blog posts and social media tutorials so I think it's popular. (ETA: also is how the subplot mosaic guide is written, see 24891)

Plus the section headers make the navigation really nice:

Pulled this out of #24470 to make reviewing easier, so this also documents the hatch keyword introduced there & therefore all the things will break until that PR is merged. Also tries to address some of #24789

QuLogic added this to the v3.7.0 milestone Jan 7, 2023
jklymak closed this Jan 11, 2023
jklymak reopened this Jan 11, 2023

jklymak commented Jan 11, 2023

Copy link
Copy Markdown
Member

Hard restarting the PR doesn't restart circle I guess. @story645 you will have to rebase on master to get hatch kwarg.

jklymak commented Jan 11, 2023

Copy link
Copy Markdown
Member

Shouldn't the title for the page change? Otherwise looks good.

story645 commented Jan 11, 2023

Copy link
Copy Markdown
Member Author

Shouldn't the title for the page change? Otherwise looks good.

To 'Bar Chart`? and what do you think about this sorta model for documenting at least plotting and other common methods? I'm honestly thinking of it as a sorta visual API doc, b/c a major advantage of being a viz library is that we can visualize a lot of the API. It ends up inherently being a bit of a how to too, but I think it's one way to address the problem of inconsistent naming of things across visualization libraries.

jklymak commented Jan 11, 2023

Copy link
Copy Markdown
Member

"Pie charts"?

story645 commented Jan 11, 2023

Copy link
Copy Markdown
Member Author

"Pie charts"?

🤦‍♀️ clearly I'm sleep deprived

QuLogic reviewed Jan 11, 2023
View reviewed changes
Comment thread examples/pie_and_polar_charts/pie_features.py Outdated
Comment thread examples/pie_and_polar_charts/pie_features.py Outdated
Comment thread examples/pie_and_polar_charts/pie_features.py Outdated
Comment thread examples/pie_and_polar_charts/pie_features.py Outdated
Comment thread examples/pie_and_polar_charts/pie_features.py Outdated
Comment thread examples/pie_and_polar_charts/pie_features.py Outdated
dstansby approved these changes Jan 12, 2023
View reviewed changes

dstansby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Some minor non-blocking suggestions, but much improved over the previous version!

Comment thread examples/pie_and_polar_charts/pie_features.py Outdated
Comment thread examples/pie_and_polar_charts/pie_features.py Outdated
Comment thread examples/pie_and_polar_charts/pie_features.py Outdated
Comment thread examples/pie_and_polar_charts/pie_features.py Outdated
Comment thread examples/pie_and_polar_charts/pie_features.py Outdated
Comment thread examples/pie_and_polar_charts/pie_features.py Outdated
story645 force-pushed the pie-example branch 2 times, most recently from 11d528d to 00cff21 Compare January 12, 2023 23:24

ksunden commented Jan 13, 2023

Copy link
Copy Markdown
Member

circle is caught because it's using the pre-merge config (which specifies python 3.8) but post-merge code (and setup.py, which specifies 3.9 as the minimum) Should be resolved with a rebase, which will have the up to date circle config.

story645 force-pushed the pie-example branch 2 times, most recently from 58e3f79 to 9d04a5c Compare January 19, 2023 20:23

QuLogic commented Jan 19, 2023

Copy link
Copy Markdown
Member

You have some ######... that should be replaced by # %% now.

expanded basic pie example
8609ed3 
added small examples of labels,
autopct, colors, hatch, and distance in an attempt to scaffold up to
exploding example
addresses some of matplotlib#24789

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
QuLogic merged commit 3309b15 into matplotlib:main Jan 20, 2023

lumberbot-app Bot commented Jan 20, 2023

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 3309b152f56e06e1ddc0d1ab91adc245a1a8c1a5
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24812: [Doc] expanded basic pie example'
  1. Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-24812-on-v3.7.x
  1. Create a PR against branch v3.7.x, I would have named this PR:

"Backport PR #24812 on branch v3.7.x ([Doc] expanded basic pie example)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

story645 pushed a commit to story645/matplotlib that referenced this pull request Jan 20, 2023
Backport PR matplotlib#24812: [Doc] expanded basic pie example
9ebd023

QuLogic commented Jan 20, 2023

Copy link
Copy Markdown
Member

Oh right, the # %% change conflicts now; up to you if you want to backport.

story645 pushed a commit to story645/matplotlib that referenced this pull request Jan 20, 2023
Backport PR matplotlib#24812: [Doc] expanded basic pie example
bc6566b
story645 pushed a commit to story645/matplotlib that referenced this pull request Jan 20, 2023
Backport PR matplotlib#24812: [Doc] expanded basic pie example
dd2c3fb
story645 deleted the pie-example branch January 20, 2023 02:40

story645 commented Jan 20, 2023

Copy link
Copy Markdown
Member Author

#25034

QuLogic added a commit that referenced this pull request Jan 20, 2023
Merge pull request #25034 from story645/auto-backport-of-pr-24812-on-…
f4069f3 
…v3.7.x

Backport PR #24812 on branch v3.7.x ([Doc] expanded basic pie example)
ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic left review comments
dstansby dstansby approved these changes

Assignees

No one assigned

Labels

Documentation topic: plotting methods

Projects

None yet

Milestone

v3.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL