FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

MEP12: Example clean-up for reference by tonysyu · Pull Request #2474 · matplotlib/matplotlib · GitHub

MEP12: Example clean-up for reference - #2474

Merged
pelson merged 21 commits into
matplotlib:masterfrom
tonysyu:canonical-example-refactor
Jan 14, 2014
Merged

pelson merged 21 commits into
matplotlib:masterfrom
tonysyu:canonical-example-refactor

Conversation

tonysyu commented Sep 29, 2013

Copy link
Copy Markdown
Contributor

This PR is meant as a reference for clean-ups that should take place as part of the Gallery clean ups outlined in MEP12.

NelleV commented Oct 3, 2013

Copy link
Copy Markdown
Member

That looks good to me. Are we sure that there are no explicit links to this example in the documentation ?

Also, can you squash some of those commits. That's a long list for the size of the patch :)

Else, I'm 👍

Copy link
Copy Markdown
Member

I am against squashing this. That list is an excellent bulletted list of
the kinds of changes that are needed. And it makes it very easy to
reference an example of each.

NelleV commented Oct 3, 2013

Copy link
Copy Markdown
Member

Squashing commits doesn't mean removing the content of the commit messages.

tonysyu commented Oct 4, 2013

Copy link
Copy Markdown
Contributor Author

Actually, I wanted to be as specific as possible with each commit. There were a few I might have wanted to group together, but for the most part each one gives a good, isolated description of different types of changes. This is important because I use these commits as concrete examples in the MEP (which links directly to commits).

And yes, as far as I can tell, none of the docs link to this example.

Copy link
Copy Markdown
Member

Is there any reason this has not been merged?

pelson added a commit that referenced this pull request Jan 14, 2014
pelson merged commit d81498f into matplotlib:master Jan 14, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL