FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

MEP12 on alignment_test.py by domspad · Pull Request #4653 · matplotlib/matplotlib · GitHub

MEP12 on alignment_test.py - #4653

Merged
jenshnielsen merged 1 commit into
matplotlib:masterfrom
domspad:MEP12-on-alignment_test.py
Jul 12, 2015
Merged

jenshnielsen merged 1 commit into
matplotlib:masterfrom
domspad:MEP12-on-alignment_test.py

Conversation

domspad commented Jul 11, 2015

Copy link
Copy Markdown

pylab to plt

jenshnielsen added a commit that referenced this pull request Jul 12, 2015
jenshnielsen merged commit 58064c3 into matplotlib:master Jul 12, 2015
jenshnielsen added the MEP: MEP12 gallery and examples improvements label Jul 12, 2015

domspad commented Jul 14, 2015

Copy link
Copy Markdown
Author

hey @jenshnielsen, just a quick clarification on these pull requests - since we are just correcting the from pylab import * parts of the #2474 (MEP12) issue right now with these examples. If I make any more changes to them with regards to the other bullet points in MEP12, should they be in a new branch? Or can I continue on this branch even though it is closed?

Copy link
Copy Markdown
Member

@domspad Thanks for all your work. You can continue on the same branch as long as the pull request is not merged when it is merged please open a new one to make more changes. You can probably open a new pull request from the same branch (Github should automatically detect that some of the commits have been merged) but for clarity I would recommend that you open a new one.

Copy link
Copy Markdown
Member

@domspad however if you want to do more work on an open pull request please just leave a note about not merging it, or better edit the title to say don't merge yet or something.

domspad deleted the MEP12-on-alignment_test.py branch July 14, 2015 02:57

Copy link
Copy Markdown
Member

I usually add a "[WIP]" to the name of the PR if it is a work in progress.
On Jul 13, 2015 9:44 PM, "Jens Hedegaard Nielsen" notifications@github.com
wrote:

@domspad https://github.com/domspad however if you want to do more work
on an open pull request please just leave a note about not merging it, or
better edit the title to say don't merge yet or something.

—
Reply to this email directly or view it on GitHub
#4653 (comment)
.

QuLogic added this to the v1.5.0 milestone Nov 4, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MEP: MEP12 gallery and examples improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL