Repository navigation
FIX: only try to update blit caches if the canvas we expect - #25085
tacaswell merged 3 commits into
Conversation
Sorry, something went wrong.
| def _clear(self, event): | ||
| """Internal event handler to clear the buttons.""" | ||
| if self.ignore(event): | ||
| if self.ignore(event) or self.canvas is not self.ax.figure.canvas: |
There was a problem hiding this comment.
I wonder if you want to wrap this in a small method with an explanation like your explanation below as the doc string:
def _not_orig_canvas():
"""
Explain
""""
return self.canvas is not self.ax.figure.canvas
Perhaps thats too much cruft, but otherwise this is a bit of a mysterious clause.
Sorry, something went wrong.
There was a problem hiding this comment.
done.
Sorry, something went wrong.
Because we may switch the canvas to a different type (that may not support blitting) when saving, check it `_clear` that the current canvas is the canvas we expect when we update the blitting caches on the draw_event callback. Closes matplotlib#25075
|
Did the rebase as it was the result of conflicts with undeprecating clear in widgets |
Sorry, something went wrong.
There is not a singular canvas
|
Anyone should merge when Azure finally times out ;-) |
Sorry, something went wrong.
|
I'm pretty sure the failed Azure test was just a known somewhat flaky test... but it was in fact test_blit, so going to make sure by re-running. |
Sorry, something went wrong.
…the canvas we expect
…085-on-v3.7.x Backport PR #25085 on branch v3.7.x (FIX: only try to update blit caches if the canvas we expect)
Because we may switch the canvas to a different type (that may not support blitting) when saving, check it _clear that the current canvas is the canvas we expect when we update the blitting caches on the draw_event callback.
Closes #25075