Repository navigation
Fix pickling of AxesWidgets. - #28430
Merged
QuLogic merged 5 commits intoJul 4, 2024
Merged
QuLogic merged 5 commits into
QuLogic merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
QuLogic
approved these changes
Jun 21, 2024
ksunden
previously approved these changes
Jun 26, 2024
ksunden
dismissed
their stale review
June 26, 2024 19:45
SpanSelector sets the canvas attrubute in __init__, which fails because it is readonly now
QuLogic
requested changes
Jun 26, 2024
QuLogic
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This apparently breaks SpanSelector.
Sorry, something went wrong.
anntzer
force-pushed
the
pw
branch
2 times, most recently
from
31be678 to
f13e212
Compare
June 26, 2024 22:00
There's no need to hold onto the (non-picklable) canvas as an attribute.
tacaswell
reviewed
Jun 27, 2024
Comment thread
lib/matplotlib/widgets.py
Copy link
Copy Markdown
Contributor
Author
|
Now fixed; the test failure is unrelated. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Test failure is not unrelated, it is the newly added test |
Sorry, something went wrong.
QuLogic
approved these changes
Jul 3, 2024
ksunden
approved these changes
Jul 3, 2024
ksunden
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Anyone can merge on CI finishing
Sorry, something went wrong.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 4, 2024
QuLogic
added a commit
that referenced
this pull request
Jul 4, 2024
…430-on-v3.9.x Backport PR #28430 on branch v3.9.x (Fix pickling of AxesWidgets.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no need to hold onto the (non-picklable) canvas as an attribute.
Closes #22482.
PR summary
PR checklist