| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I pushed a change without rebasing just to see what Mypy would do. It's running.... |
Sorry, something went wrong.
|
@ksunden could you help me decipher this Mypy failure? |
Sorry, something went wrong.
| # Index Locator | ||
| setup(axs[4], title="IndexLocator(base=0.5, offset=0.25)") | ||
| axs[4].plot(range(0, 5), [0]*5, color='white') | ||
| axs[4].plot([0]*5, color='white') |
There was a problem hiding this comment.
It's not completely obvious from looking at this example what the difference is between MultipleLocator and IndexLocator. But from the API docs it seems to me that IndexLocator makes most sense when the axis does not have numbers associated with it. So I took out the x-values.
I clearly should have done more homework before the Thursday call, then I would have known that offset is already used as a locator param 🤦♀️
Sorry, something went wrong.
|
I think this is now ready for review. I have not [yet] added a what's new entry, as I'm still pretty unclear in general what the criteria are for deciding to do so. |
Sorry, something went wrong.
.. versionadded:: 3.8 I think (or just that it is nice to showcase some new features!). (I happened to read https://matplotlib.org/stable/devel/coding_guide.html#new-features-and-api-changes the other day...) Parameter makes sense! (Will review code when I have a bit more time.) |
Sorry, something went wrong.
|
Yes this should definitely get what's new entry |
Sorry, something went wrong.
|
OK thanks. What's new now added. |
Sorry, something went wrong.
Co-authored-by: Ruth Comer 10599679+rcomer@users.noreply.github.com
| Back | FazBrowse Home | New Git URL |
PR Summary
Picked up from #21168. Adds an offset parameter to MultipleLocator so the ticks can all be shifted by a given value.
### To Do
1. Agree whether offset is the best name for the new parameter.
2. Address documentation tasks in the below checklist, but I wanted to get feedback on the principle and the parameter name before I went all in.
PR Checklist
Documentation and Tests
Release Notes