| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
The case that may need to be looked at a bit is the missing stub case, as that does not have a stub path to parse. Edit: on second thought, it may give the path of the parent object or just line 0 of the module, but still worth a look |
Sorry, something went wrong.
|
Would that be for a new Python file entirely? |
Sorry, something went wrong.
|
No, just for a new method is what I was thinking |
Sorry, something went wrong.
|
The stubtest output for that case doesn't include a line number, so it doesn't get posted, but the other errors do work fine. I'm not sure if I can get it to fall back to posting on the .py or if it would confuse it. |
Sorry, something went wrong.
|
I also just added an extra function in the stub, but not the Python file, and I see that that doesn't get posted either; it looks like there's a slightly difference in output in that case, which I should be able to cover. |
Sorry, something went wrong.
|
OK, this is now able to post 1) differences between stubs and runtime; 2) items in stubs but not in runtime. Unfortunately, the case with items in runtime but not stubs cannot be caught, AFAICT. |
Sorry, something went wrong.
|
I opened an issue on stubtest to see if concise error messages could contain a bit more information (linked above). This could simplify this posting process as message would not be multiline. |
Sorry, something went wrong.
There was a problem hiding this comment.
Let's try this and see what happens.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Unfortunately, the way that stubtest outputs its error messages makes it difficult to post a message on both the .py and .pyi stub, so we decided to take the full message and post it only on one.
As a test, I have made PR in my repo QuLogic#30 which started from the previously-unfixed #25542, and then I also added a commit with multiple argument mismatches to confirm that stubtest didn't output some different format.
Results are at the bottom of https://github.com/QuLogic/matplotlib/pull/30/files
PR Checklist
Documentation and Tests
Release Notes