| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Should we run isort on these as well? |
Sorry, something went wrong.
|
We could do so, though may wish to add config to e.g. group the mpl.typing, typing (stdlib), and numpy.typing imports together (potentially with collections.abc as well, as that is also rather related) Not opposed, but also don't really see it as a huge gain. |
Sorry, something went wrong.
| from matplotlib import cbook, ft2font | ||
| from matplotlib._fontconfig_pattern import ( | ||
| generate_fontconfig_pattern, | ||
| parse_fontconfig_pattern, |
There was a problem hiding this comment.
Weirdly, this one is public enough to appear in API change notes, but not public enough to be in API documentation.
Sorry, something went wrong.
There was a problem hiding this comment.
Yeah, I was debating on this one, current leaning is to leave it out of stubs until and unless someone complains, which I kind of doubt will happen.
Sorry, something went wrong.
mostly performed by running pycln, but then manually audited
|
Gentle ping on this one |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
mostly performed by running pycln, but then manually audited
After it was brought up in #25728 (comment), I did a bit of a review, and consulted the python/typeshed repo for guidance on best practices for type stub files.
That repo has a precommit hook to run pycln -a on all files, which removes any imports that are implementation details that are not used in the public interface of the module.
Since that is the prevailing best practice of the relative authority on the matter, I decided to run pycln over our code.
The following additional changes were made after auditing the results:
pycln could be added as a pre-commit hook here if we were interested, but would need to be properly configured, and current personal leaning is that it is not a big enough boon to do so, though checking when the topic comes up like it did here may be warranted.
PR Checklist
Linked Issue
Documentation and Tests
Release Notes