Repository navigation
Re-export textpath types in text - #26210
Merged
tacaswell merged 1 commit intoJun 29, 2023
Merged
tacaswell merged 1 commit into
tacaswell merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The former location was deprecated in 3.7, and accidentally removed earlier during some cleanup.
ksunden
approved these changes
Jun 28, 2023
tacaswell
approved these changes
Jun 28, 2023
Copy link
Copy Markdown
Member
|
Should he have expected stubtest to have caught this? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
No, stubtest won't catch it because it ignores imported names (unless they are in __all__ or have import foo as foo) I noted it in #25787 as something that pycln did that I wanted to undo, but apparently missed actually undoing it like I did for the mathtext reexports. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
The former location was deprecated in 3.7 (#23576), and accidentally removed earlier during some cleanup (#25787).
PR checklist