FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[TYP] Reduce stubtest ignores by ksunden · Pull Request #25844 · matplotlib/matplotlib · GitHub

Repository navigation

[TYP] Reduce stubtest ignores - #25844

Merged
timhoffm merged 1 commit into
matplotlib:mainfrom
ksunden:allowlist_reduction
May 23, 2023
Merged

timhoffm merged 1 commit into
matplotlib:mainfrom
ksunden:allowlist_reduction

Conversation

ksunden commented May 9, 2023

Copy link
Copy Markdown
Member

PR summary

Broadly makes the type hints more reflective of runtime behavior, though does incur some type:ignore comments because of sub/superclass interactions

In particular, mypy does not approve of making parameters to methods mandatory for subclasses (it is fine with adding optional params, just not making valid superclass calls invalid).
Nor does it approve of removing even an optional param (for the same reason).

Helper _path functions which are undocumented are no longer exported in the transforms namespace.

Some additional comments added regarding corner cases of typing/explaining new ignores

PR checklist

Broadly makes the type hints more reflective of runtime behavior, though does incur some type:ignore comments because of sub/superclass interactions
oscargus added this to the v3.8.0 milestone May 23, 2023
timhoffm merged commit 7d7f6da into matplotlib:main May 23, 2023
rcomer mentioned this pull request May 25, 2023
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL