| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
(Deleted my comment since I realized that it can be both an empty set and None.) Seems like this breaks several other things. |
Sorry, something went wrong.
|
I'm not sure which fix is better, or if there is any other superior solution available. Based on the commit history, there are two potential fixes:
Note that it assumes labelOnlyBase is True for all the major formatters while False for minor formatters, which could contradict with the doc stating:
What about "abnormally"? Can a major formatter have 'labelOnlyBase' set to False? Is there an exceptional case?
When minor_thresholds is set to (0, 0), namely, numdec > subset, a formatter labels bases only whether labelOnlyBase is True or not. In the example from issue #25896, its outcome is as follows: import matplotlib.pyplot as plt
import matplotlib.ticker as mticker
fig, ax = plt.subplots()
ax.set_yscale("log")
formatter = mticker.LogFormatter(minor_thresholds=(0,0))
ax.yaxis.set_minor_formatter(formatter)
ax.set_ylim(10, 20)
formatter(10) # '10'
formatter(11) # ''
formatter(12) # ''
formatter(13) # ''
formatter(14) # ''
formatter(15) # ''
formatter(16) # ''Furthermore, what does the term "classic" style refer to in the documentation? Maybe we could provide a more precise description. |
Sorry, something went wrong.
|
Classic is the pre-2.0 default style. |
Sorry, something went wrong.
fix test failures alternative fix fix format remove irrelevant code remove label_expected
|
Hi @oscargus, could you review the PR again? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR summary
PR checklist