ci: Don't install recommended packages on Ubuntu - #26505
Merged
story645 merged 2 commits intoAug 24, 2023
Merged
story645 merged 2 commits into
story645 merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Looking through the results it seems that everything is good. There's just a failure of some font tests because of an outdated cache. |
Sorry, something went wrong.
We don't need the optional packages and save a little download/install time.
QuLogic
marked this pull request as ready for review
August 14, 2023 18:12
ksunden
approved these changes
Aug 14, 2023
story645
approved these changes
Aug 23, 2023
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
not sure if you want this squash merged or regular merged so leaving it for you to self merge.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I'll always prefer regular merge. |
Sorry, something went wrong.
2 tasks done
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
We don't need the optional packages and can save a little download/install time.
Also, update the WQY ZenHei package name, as apt has been noting it's outdated for a while.
Draft because I need to confirm that we actually don't need any optional things.
PR checklist