FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

issue: 26871 - Remove SimplePath class from patches.py by prateetishah · Pull Request #26876 · matplotlib/matplotlib · GitHub

issue: 26871 - Remove SimplePath class from patches.py - #26876

Closed
prateetishah wants to merge 10 commits into
matplotlib:mainfrom
prateetishah:remove-patches-py
Closed

prateetishah wants to merge 10 commits into
matplotlib:mainfrom
prateetishah:remove-patches-py

Conversation

Copy link
Copy Markdown

PR summary

This PR removes the deprecated code during the version 3.7 from lib/matplotlib/patches.py which is a sub issue in the parent issues here: #26865

PR checklist

prateetishah changed the title issue: 26871 - Remove SimplePath class which is deprecated since 3.7 issue: 26871 - Remove SimplePath class from patches.py Sep 22, 2023
@@ -0,0 +1,3 @@
Remove Deprecated API
~~~~~~~~~~~~~~~~~~~~~~~
``matplotlib.patches.SimplePath``

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you check the deprecation note an copy over the alternative if any?

Copy link
Copy Markdown
Member

ksunden commented Sep 25, 2023

Copy link
Copy Markdown
Member

The git history here seems to be messy and includes unrelated commits from e.g. #26505, but overwrites their commit messages.

We will also need to sort out between this and #26890, which also is doing the same deprecation task (and while that author closed/reopened several PRs, did get the first one as #26875, if we use that as the metric)

ksunden commented Oct 11, 2023

Copy link
Copy Markdown
Member

Thank you for your efforts here, however we elected to merge another PR that took on this portion of this task. We hope to hear from you again

ksunden closed this Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL