Removing deprecated api from patches - #26890
Merged
ksunden merged 11 commits intoOct 11, 2023
Merged
ksunden merged 11 commits into
ksunden merged 11 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@gaurichaudhari9 No need to open and close PRs. Just push changes to the existing PR and CI will rerun. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Noted. I’ll keep that in mind |
Sorry, something went wrong.
QuLogic
approved these changes
Sep 25, 2023
QuLogic
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
If you are comfortable rebasing and squashing this down to one commit, please do so. Otherwise, I suggest that the person who merges does so.
Sorry, something went wrong.
This was referenced Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This pr targets and attempts to remove the deprecation in 3.7 found in lib/matplotlib/patches.py
The deprecated items marked with @_api.deprecated("3.7") are removed.
PR checklist