FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

#26865 removing deprecations to axislines.py by farrjere · Pull Request #26900 · matplotlib/matplotlib · GitHub

/ matplotlib Public

#26865 removing deprecations to axislines.py - #26900

Merged
QuLogic merged 1 commit into
matplotlib:mainfrom
farrjere:deprecated
Oct 19, 2023
ConversationCommits (1)ChecksFiles changed
Merged

#26865 removing deprecations to axislines.py#26900
QuLogic merged 1 commit into
matplotlib:mainfrom
farrjere:deprecated

Conversation

farrjere commented Sep 23, 2023

Copy link
Copy Markdown
Contributor

PR summary

This PR removes the depcrecated code during the version 3.7 from patches.py and axislines.py for the issue #26865

PR checklist

github-actions Bot reviewed Sep 23, 2023
View reviewed changes

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

farrjere force-pushed the deprecated branch 3 times, most recently from acb4a7f to 5044e8f Compare September 24, 2023 14:05
oscargus reviewed Sep 25, 2023
View reviewed changes

oscargus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

I think this is good, subject to updating the wording of the release note.

Comment thread doc/api/next_api_changes/removals/26900-jf.rst Outdated
Comment thread doc/api/next_api_changes/removals/26900-jf.rst Outdated
oscargus added the API: changes Changes to the public API, typically requiring deprecation. label Sep 25, 2023

oscargus commented Sep 25, 2023

Copy link
Copy Markdown
Member

For a second reviewer: there is a PR open for patches, #26890, but this can go in as is, the other requires some updates.

ksunden mentioned this pull request Sep 25, 2023
Closed
14 tasks done

ksunden commented Oct 11, 2023

Copy link
Copy Markdown
Member

We merged another PR that addressed the patches portions of this, @farrjere can you refocus this PR on only the axislines portion?

ksunden reviewed Oct 17, 2023
View reviewed changes
Comment thread lib/matplotlib/patches.pyi Outdated
Comment on lines +457 to +461
class _Base(ConnectionStyle):
@ api.deprecated("3.7")
class SimpleEvent:
def __init__(self, xy: tuple[float, float]) -> None: ...
def __init__(self, xy):
self.x, self.y = xy

ksunden Oct 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We do not wish to add this back, especially as this is a pyi stub file (where @api.deprecated has no effect)

ksunden requested changes Oct 17, 2023
View reviewed changes

ksunden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please revert changes to patches.pyi

ksunden commented Oct 17, 2023

Copy link
Copy Markdown
Member

Needs a rebase because an adjacent bit of code was modified (adding a new deprecation for the 3.9 cycle). That deprecation should be kept, but the removal of the passthru_pt attr should still happen.

farrjere commented Oct 17, 2023

Copy link
Copy Markdown
Contributor Author

Wouldn't handling the merge conflict handle that? I went to do this myself but it resulted in an issue with _version.py having a formatting issue that couldn't commit (coming from the merge).

ksunden commented Oct 17, 2023

Copy link
Copy Markdown
Member

Rebasing is our preferred method of handling merge conflicts.

_version.py should not be committed into the repo (it is a build artifact, and you are seeing it as a result of the change of build system #26621) I would suggest running git clean -fdx first (and reinstalling after updating to the meson-based branch).

The patch as submitted has additions to patches.pyi, which should not be included.

QuLogic added this to the v3.9.0 milestone Oct 19, 2023
QuLogic merged commit dfdb37a into matplotlib:main Oct 19, 2023

QuLogic commented Oct 19, 2023

Copy link
Copy Markdown
Member

Thanks @farrjere! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

QuLogic changed the title #26865 removing deprecations to patches.py and axislines.py #26865 removing deprecations to axislines.py Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments
ksunden ksunden approved these changes
oscargus oscargus approved these changes

Assignees

No one assigned

Labels

API: changes Changes to the public API, typically requiring deprecation.

Projects

First Time Contributors
Status: Merged

Milestone

v3.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL