Repository navigation
ENH: Added sharex/sharey string support to subplot_mosaic - #32437
nillohitroy wants to merge 11 commits into
Conversation
Sorry, something went wrong.
|
Thank you for opening your first PR into Matplotlib! If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process. You can also join us on discourse chat for real-time discussion. For details on testing, writing docs, and our review process, please see the developer guide. We strive to be a welcoming and open project. Please follow our Code of Conduct. |
Sorry, something went wrong.
|
Dear Maintainers, |
Sorry, something went wrong.
|
Assuming that I'm talking to an actual human: this PR is currently failing to pass the Linting and MyPy Stubtest checks. The AppVeyor build failure is somewhat expected as AppVeyor has been flaky recently. Generally, you will want to make sure that all checks pass on any PR that you open to a repository. You need to get at least Linting and the stub test to pass first. |
Sorry, something went wrong.
Thank you sir.. on it.. |
Sorry, something went wrong.
as discussed in matplotlib#32320 (comment)
* Remove print() from test * Add mock to ensure manual_alpha called
Closes matplotlib#32409. Co-authored-by: hannah <story645@gmail.com>
|
Hi @iccir |
Sorry, something went wrong.
|
I think a rebase should sort that out. Assuming you have set the upstream remote as described here, try this: Make a backup branch in case something else goes wrong git branch my-backup-branch Rebase on the upstream branch git fetch upstream git rebase upstream/main git push will then fail, but you can git push --force-with-lease |
Sorry, something went wrong.
|
Hey, it happens - git can be tricky :) It looks like you made two commits: I'd do something like the following: git diff \
c278400dee9b6758ce74f0eab9b5cbc085b595ee^ \
a14df4f320b0b13ebdf7fc34cf4d356e5f0f67ea > \
/someplace/safe/changes.patch
Then I'd follow @rcomer's instructions above. You can always reapply the patch with: git apply /someplace/safe/changes.patch |
Sorry, something went wrong.
PR summary
This PR implements string arguments ('all', 'row', 'col') and boolean True/False for sharex and sharey in subplot_mosaic() for #18305 .
To handle complex and nested layouts, the axes are grouped based on their specific GridSpec and exact rowspan/colspan coordinates. Axes only share a row or column if their spans are identical.
For example, consider a layout where C and D span both rows:
If sharey='row' is passed, the code forms three isolated sharing groups based on their vertical spans:
Once the groups are isolated, the logic designates the first axis in each list as the parent and calls standard .sharex(parent) or .sharey(parent) on the remaining children in that specific group.
Important Note: Relying on Matplotlib's global ax._label_outer_xaxis() or ax._label_outer_yaxis() inadvertently hid tick labels for inner subplots if they formed their own isolated sharing group. For this very reason, I implemented a custom logic which calculates label visibility dynamically per group. For example, in an X-axis sharing group, it calculates the physical bottom edge by finding the max() of rowspan.stop across just the group's members. It then loops through that group and applies ax.tick_params(labelbottom=False) to any axis sitting above that localized bottom edge.
AI Disclosure
I have used Generative AI to understand the codebase (specifically the code for the issue), setting up of the environment (installing packages and dependencies required), the intent of the issue and to get to the center of the problem. It is also important to mention that AI was used to understand the requirements of the maintainers and how #32239 failed and what to avoid while coding.
Verification
I have tested the code for a local matplotlib development build, running it on my system and creating a sample plot for a sample data. Also, I have written some test cases for the same by trying to incorporate as many test cases as possible (5), all of which successfully passed.
I would be happy for any feedback regarding any portion of the code!!
PR quality check