Repository navigation
MNT: Update numpy and pyparsing minimums in _check_versions - #32472
Merged
timhoffm merged 1 commit intoOct 13, 2026
Merged
timhoffm merged 1 commit into
timhoffm merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
timhoffm
approved these changes
Oct 13, 2026
timhoffm
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I consider this an obvious low-risk change. In favor of review efficiency I skip the second review. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
pyproject.toml asks to update matplotlib._check_versions() whenever
the dependency list changes. Two recent bumps missed it:
This PR sets them to 2.0 and 3.0 respectively. The cycler bump from the same
release cycle already updated this list, so numpy and pyparsing are
the only entries out of sync.
AI Disclosure
Claude Code (Claude Opus 5.5 (high) ) found this while reviewing codebase.
PR quality check