| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Note that pyparsing 3.0 requires Python 3.6 or later. |
Sorry, something went wrong.
|
I also discovered that there are several non-PEP8 attributes on ParserElement, specifically resultsName - which has a couple of referenes in matplotlib. As I did not set up the PEP8 synonyms for that attribute (or several others), it will unfortunately remain. (Since it has no leading underscore, it is fair game for users to assume it is part of the public API - an important lesson learned...) I'll implement the synonyms for resultsName and the other non-PEP8 public attributes in 3.3.0 or possibly even 3.2.2, but they will not emit the DeprecationWarnings until at least 4.0. |
Sorry, something went wrong.
Thanks for the hint. I think it's not a problem in practice. Per our dependency policy we are requiring |
Sorry, something went wrong.
|
At the library level we should provide functional floors to our version pinning (using caps only if we know it will break us) and leave retro-actively adjusting pins to packagers / integrators. |
Sorry, something went wrong.
|
Do you want to keep commits or should this be squashed? - Either way, you can merge yourself. |
Sorry, something went wrong.
|
I'm about to release pyparsing 3.3.0 next month, but the latest 3.10.6 release of matplotlib still emits DeprecationWarnings. I thought this work got merged in - I guess "merged" doesn't necessarily mean "goes out in the next release." How can I coordinate my 3.3.0 release with matplotlib to head off a storm of "I'm getting DeprecationWarnings now!" reports? |
Sorry, something went wrong.
|
Thanks for the heads-up. We are a bit later than originally planned with the 3.11 release, but should possibly have put the changes in the 3.10.x bugfix releases. I'll do that now, but I'm unsure whether we'll still do a 3.10.7. Eithe way, we need to coordinate, because we indeed don't want the deprecation warnings to show up with users. |
Sorry, something went wrong.
…s from pyparsing * Bump minimum pyparsing version * Use PEP8 method names from pyparsing * Add api note * Clean up pyparsing<3 code * Remove unused import * Clean up pyparsing import * Sort imports (cherry picked from commit d55bdde)
Will definitely do so. I have a set of matplotlib tests as part of my unit tests, so that I can see this before releasing. |
Sorry, something went wrong.
…0589) * Backport PR #29745: Use PEP8 style method and function names from pyparsing * Bump minimum pyparsing version * Use PEP8 method names from pyparsing * Add api note * Clean up pyparsing<3 code * Remove unused import * Clean up pyparsing import * Sort imports (cherry picked from commit d55bdde) * Remove erroneous pillow bump Co-authored-by: Thomas A Caswell <tcaswell@gmail.com> * Update pyproject.toml Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com> --------- Co-authored-by: David Stansby <dstansby@gmail.com> Co-authored-by: Thomas A Caswell <tcaswell@gmail.com> Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
| Back | FazBrowse Home | New Git URL |
PR summary
See #29722 for context, this prepares for a pyparsing 3.3.0 release. This requires a bump of the minimum version to 3.0. That was released in 2021, so is easily within our dependency policy of at >= 12 months.
PR checklist