FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

TST: Fix test_websocket_rejects_cross_origin on latest tornado by QuLogic · Pull Request #32516 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

TST: Fix test_websocket_rejects_cross_origin on latest tornado #32516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 3 commits into from
Oct 22, 2026
+15 −17
Conversation 4 Commits 3 Checks 41 Files changed 1
Merged

TST: Fix test_websocket_rejects_cross_origin on latest tornado #32516

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68afc2d
TST: Fix test_websocket_rejects_cross_origin on latest tornado
QuLogic Oct 21, 2026
0566934
TST: Drop positive cases from test_websocket_rejects_cross_origin
QuLogic Oct 21, 2026
b6af72c
TST: Avoid using real domain names in tests
QuLogic Oct 22, 2026
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
32 changes: 15 additions & 17 deletions lib/matplotlib/tests/test_backend_webagg.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -56,25 +56,23 @@ def test_toolbar_button_dispatch_allowlist():
assert canvas.toolbar.method_calls == []


@pytest.mark.parametrize("host, origin, allowed", [
("localhost:8988", "http://localhost:8988", True),
("localhost:8988", "http://evil.com", False),
("localhost:8988", "http://127.0.0.1:8988", False),
("localhost:8988", "http://[::1]:8988", False),
("127.0.0.1:8988", "http://127.0.0.1:8988", True),
("127.0.0.1:8988", "http://localhost:8988", False),
("127.0.0.1:8988", "http://[::1]:8988", False),
("[::1]:8988", "http://[::1]:8988", True),
("[::1]:8988", "http://[::2]:8988", False),
("[::1]:8988", "http://localhost:8988", False),
("[::1]:8988", "http://evil.com", False),
@pytest.mark.parametrize("host, origin", [
("localhost:8988", "http://example.com"),
("localhost:8988", "http://127.0.0.1:8988"),
("localhost:8988", "http://[::1]:8988"),
("127.0.0.1:8988", "http://localhost:8988"),
("127.0.0.1:8988", "http://[::1]:8988"),
("[::1]:8988", "http://[::2]:8988"),
("[::1]:8988", "http://localhost:8988"),
("[::1]:8988", "http://example.com"),
])
def test_websocket_rejects_cross_origin(host, origin, allowed):
def test_websocket_rejects_cross_origin(host, origin):
"""Verify Tornado's default check_origin rejects cross-origin requests."""
pytest.importorskip("tornado")
from matplotlib.backends.backend_webagg import WebAggApplication

ws = WebAggApplication.WebSocket.__new__(WebAggApplication.WebSocket)
ws.request = MagicMock()
ws.request.headers = {"Host": host}
assert ws.check_origin(origin) is allowed
app = WebAggApplication()
request = MagicMock()
request.headers = {"Host": host}
ws = WebAggApplication.WebSocket(app, request)
assert not ws.check_origin(origin) # Not allowed.
Loading
Back | FazBrowse Home | New Git URL