Repository navigation
TST: Fix test_websocket_rejects_cross_origin on latest tornado - #32516
timhoffm merged 3 commits into
Conversation
Sorry, something went wrong.
There's no need to go through the non-standard `__new__` instead of the normal constructor.
|
Note, this fixes the exception, but 3 of the origins now fail. I will investigate that now. |
Sorry, something went wrong.
|
In 6.6, we have this change to check_origin:
And the failing tests are all where Origin == Host and thus should pass, but since this is checked elsewhere, check_origin no longer bothers to allow it. This checking is in a private method, so I think it might be best to just drop these cases. |
Sorry, something went wrong.
Tornado 6.6 changed how this works internally, and now `WebSocket.check_origin` does not accept origin==host, which is checked prior in a private method. This test is mainly just to confirm that everything is working as expected for invalid requests, so just drop the valid ones instead of trying work around the new behaviour.
example.com (while real) is specifically designated for documentation, not testing, but we don't actually connect to it. Co-authored-by: Ricci Adams <1097294+iccir@users.noreply.github.com>
PR summary
There's no need to go through the non-standard __new__ instead of the normal constructor.
AI Disclosure
None
PR quality check