Repository navigation
Only use asynchronous redraw methods when handling GUI events in Qt5Agg (fix #4604) - #4612
tacaswell merged 2 commits into
Conversation
Sorry, something went wrong.
|
For testing purposes I removed the update/redraw() switch for windows that was introduced because windows users reported a insufficient amount of actual redraws on Qt4Agg/Win. It could be possible that this was actually the same problem back then if Qt4/Win emitted events more frequently than Qt4/X11 or Qt4/OSX. Could a Windows user confirm that Qt5Agg is working fine with this PR? |
Sorry, something went wrong.
|
The _priv_update code is duplicated in the qt4agg backend as well. |
Sorry, something went wrong.
|
I can confirm both the bug and that this fixes it. Both the qt4 and qt5 backends work fine wrt pan/zoom updates for me with this. I am going to merge this now and make a note with the RC that this will need testing on mac + windows. |
Sorry, something went wrong.
FIX: Only use asynchronous redraw methods when handling GUI events in Qt5Agg Fix #4604
When handling events like mouse movements during zoom/pan, the Qt5 backend forced a redraw of the Agg canvas for every event. Redraw operations should be done only when the GUI is ready to display another frame, else the rendering performance is going to be crushed on systems where Qt emits events more frequently.