FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Image options by anntzer · Pull Request #5469 · matplotlib/matplotlib · GitHub

Repository navigation

Image options - #5469

Merged
mdboom merged 1 commit into
matplotlib:masterfrom
anntzer:image-options
Dec 16, 2015
Merged

mdboom merged 1 commit into
matplotlib:masterfrom
anntzer:image-options

Conversation

anntzer commented Nov 12, 2015

Copy link
Copy Markdown
Contributor

This patch allows the user to interactively set an image's colormap from the "axes and lines (and now images) parameters editor" (in the Qt backend).

Colormaps are listed from those registered with matplotlib.cm. Colorbars seem to be handled properly.

Note: this patch builds onto my previous PR, #5342 (also involving the options editor). If #5342 gets rejected I will split out the specifics of this PR.

mdboom added this to the proposed next point release (2.1) milestone Nov 18, 2015

Copy link
Copy Markdown
Member

👍 This now needs a re-base due to merging #5342

Only suggestion would be to filter out the *_r colormaps and add a 'reverse' check box.

anntzer commented Nov 24, 2015

Copy link
Copy Markdown
Contributor Author

Is there a generic way to get the reverse of a colormap? The current colormap could be a user-defined one, in which case it needs to be available in the combobox, but then the user may pick to use its reversed form instead, in which case I need to generate that colormap on the fly.
It does seem to be a good idea though.

Copy link
Copy Markdown
Member

There was some discussion of adding such a method, but I don't think it went anywhere. In cm.py there are functions that are used to reverse the specifications (and are how we generate the *_r color maps, but I do not know if they can be made to work on a generic color map.

If the checkbox is going to take more than 15min, I would say skip it for this PR.

anntzer commented Nov 26, 2015

Copy link
Copy Markdown
Contributor Author

I'd say it will :-) (specifically for this part, the rest is not that hard)

anntzer commented Dec 15, 2015

Copy link
Copy Markdown
Contributor Author

Kindly bumping the issue. (If there's no easy way to reverse a cmap I'll skip that functionality for now.)

mdboom commented Dec 16, 2015

Copy link
Copy Markdown
Member

Seems fine, but this needs a rebase on current master.

anntzer commented Dec 16, 2015

Copy link
Copy Markdown
Contributor Author

Done (with no rebase conflict).

This patch allows the user to interactively set an image's colormap from the
axes and lines (and now images) parameters editor (in the Qt backend).

Colormaps are listed from those registered with matplotlib.cm.  Colorbars seem
to be handled properly.
mdboom added a commit that referenced this pull request Dec 16, 2015
mdboom merged commit 590f042 into matplotlib:master Dec 16, 2015
anntzer deleted the image-options branch December 16, 2015 19:25
QuLogic modified the milestones: 2.0 (style change major release), 2.1 (next point release) Jul 10, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL