| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@anntzer this needs a rebase after your other PR got merged. |
Sorry, something went wrong.
|
Nope, it's still fine. |
Sorry, something went wrong.
|
github/The web UI disagrees with you about this needing a rebase. |
Sorry, something went wrong.
|
Sorry, I was confused by your message on the other PR regarding it being pulled in (which is not the case). Anyways, rebased both PRs. |
Sorry, something went wrong.
|
By the way, I would appreciate if someone did some manual testing of this PR too, because the figure options UI is not unit-tested (and that would not be so easy to do...). |
Sorry, something went wrong.
|
👍 does what it says on the tin. Looks like this needs a rebase. |
Sorry, something went wrong.
|
Apparently I also needed to call line.set_alpha explicitly for the alpha value to be set, not sure if something changed recently (I think this wasn't the case before). |
Sorry, something went wrong.
|
If I change those lines back to line.set_color(color) it works as expected for me. |
Sorry, something went wrong.
|
What did you try? If I call plot([1, 2], alpha=.5) then try to edit the alpha of the line, the alpha is actually not modified (when it's just line.set_color(color)). |
Sorry, something went wrong.
|
Ah, I was starting with a full alpha line and then turning it down. |
Sorry, something went wrong.
|
Ping? Milestone changed to match with #6382. |
Sorry, something went wrong.
|
Should be good to go? The issue with the need to explicitly call line.set_alpha is an independent one. |
Sorry, something went wrong.
|
Hmm, this doesn't backport cleanly. Do you mind opening another PR for it? |
Sorry, something went wrong.
|
Should I cherry-pick this to upstream/v2.x? |
Sorry, something went wrong.
|
Yes, it just doesn't do so cleanly. I'm sure you'll be able to figure it out though. |
Sorry, something went wrong.
|
@anntzer Go ahead and backport all of the editor code if that is easier. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Make alpha values accessible through the Qt figure options editor. Requires #6382 (alpha support in matplotlib.colors), closes #6196.