FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Assume that tickers respect view limits. by anntzer · Pull Request #6647 · matplotlib/matplotlib · GitHub

Repository navigation

Assume that tickers respect view limits. - #6647

Closed
anntzer wants to merge 1 commit into
matplotlib:masterfrom
anntzer:assume-ticker-respects-viewlims
Closed

anntzer wants to merge 1 commit into
matplotlib:masterfrom
anntzer:assume-ticker-respects-viewlims

Conversation

anntzer commented Jun 27, 2016

Copy link
Copy Markdown
Contributor

Tickers may return positions epsilon-outside of the view limits and we
don't want to drop them.

Fixes #6641.

Tickers may return positions epsilon-outside of the view limits and we
don't want to drop them.

anntzer commented Jun 27, 2016

Copy link
Copy Markdown
Contributor Author

I cannot reproduce the test_simplification failures locally -- can someone have a look?
test_markevery_linear_scales_zoomed fails locally even though there is no visible difference in the images acoording to the test triage tool; I guess this may be due to an extra tick on the edge, in which case I'll just generate a new reference image. Here too, another pair of eyes may be helpful.

QuLogic added this to the 2.0 (style change major release) milestone Jun 27, 2016

QuLogic commented Jun 27, 2016

Copy link
Copy Markdown
Member

They are mostly due to the tick on the edge, though curiously only for the svg tests:

  • test_simplification.test_diamond:
  • test_simplification.test_clipping:
  • test_axes.markevery_linear_scales_zoomed

QuLogic commented Jun 27, 2016

Copy link
Copy Markdown
Member

Looking at the markevery_linear_scales result, it seem like the svg->png conversion is a bit buggy. It appears as if the axes line is partially transparent (maybe 0.5 pixel wide, sort of thing?), so the ticks "bleed through". But if you look at the svg in eog, the axes is black, so there really shouldn't be a difference.

anntzer commented Jun 27, 2016

Copy link
Copy Markdown
Contributor Author

Can you generate the new baseline images (and perhaps open a new issue w.r.t. the conversion)? As mentioned above the tests pass fine locally for me, so I guess I can't generate them...

Copy link
Copy Markdown
Member

Tickers do not have to respect the view limit and are allowed to return ticks which are not visible.

anntzer commented Jun 27, 2016

Copy link
Copy Markdown
Contributor Author

Do you have a counter-example? Can we change the specification so that tickers do have to respect the view limits? (This issue is a perfect example why such a requirement would be helpful...)

efiring commented Jun 27, 2016

Copy link
Copy Markdown
Member

I think that the idea here is that tickers are used in the classic autoscaling mode to determine the view limits. When called to actually get the ticks, however, I think they are called with the view limits after this autoscaling has already been done, and with the resulting view limits, so they should be able to return only the ticks that respect those limits. How all the tickers actually behave is another question.

anntzer commented Jun 27, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Actually there seems to be another point where ticks are cropped to the actual limits: https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/axis.py#L1000
Not that smart_bounds seem to be mentioned anywhere in the docs... another good thing to get rid of?

QuLogic commented Sep 6, 2016

Copy link
Copy Markdown
Member

Replaced by #7042.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL