Repository navigation
FIX: ticks filtered by Axis, not in Tick.draw - #7042
Merged
efiring merged 2 commits intoSep 6, 2016
Merged
efiring merged 2 commits into
efiring merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Tickers may return positions epsilon-outside of the view limits and we don't want to drop them. The filtering of the ticks is done in the `_update_ticks` method of `mpl.axis.Axis` which adds a 0.5 px or pt extension onto the view limit to ensure that ticks on the edge are drawn.
tacaswell
force-pushed
the
assume-ticker-respects-viewlims
branch
from
92d6573 to
1c2281b
Compare
September 5, 2016 19:37
Copy link
Copy Markdown
Member
Author
|
@anntzer Corrected the tests and re-worded your commit message a bit to add a note about where the tick-in-view-limit filtering is actually accruing. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for taking over, I've been a bit busy recently. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I merged because I didn't see any point in waiting for Appveyor for this one; Travis passed. |
Sorry, something went wrong.
efiring
added a commit
that referenced
this pull request
Sep 6, 2016
FIX: ticks filtered by Axis, not in Tick.draw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #6647