FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Mplot3d/collection cmap fix by WeatherGod · Pull Request #762 · matplotlib/matplotlib · GitHub

Repository navigation

Mplot3d/collection cmap fix - #762

Merged
WeatherGod merged 1 commit into
matplotlib:v1.1.xfrom
WeatherGod:mplot3d/collection_cmap_fix
Mar 17, 2012
Merged

WeatherGod merged 1 commit into
matplotlib:v1.1.xfrom
WeatherGod:mplot3d/collection_cmap_fix

Conversation

Copy link
Copy Markdown
Member

Colors should no longer disappear while interacting with scatter3d plots

* Found a simple solution to the "colors disappear after interacting with
  a scatter3d plot" bug. Should close matplotlib#761 and close matplotlib#152.

sb2nov commented Mar 13, 2012

Copy link
Copy Markdown

So the quality of the image changes after you use that fix. It looks like the alpha gets messed up after that.
I have created two images to show the difference. How do I put those images up ?

sb2nov commented Mar 13, 2012

Copy link
Copy Markdown

@WeatherGod : I have mailed you the Images

Copy link
Copy Markdown
Member Author

That isn't a "quality" issue. The question is whether or not the alpha
values should be utilized to indicate depth (which is what the code was
originally supposed to do. In fact, I don't know why your "before" image
doesn't do this. What is your call to scatter?

sb2nov commented Mar 13, 2012

Copy link
Copy Markdown

self.ax = self.fig.gca(projection='3d')
self.ax.scatter(xs, ys, zs, c=c, marker='o', s=20)

Copy link
Copy Markdown
Member Author

ok... in any case, the behavior you had in the past is wrong and it appears that my patch inadvertently fixed it. Perhaps a kwarg could be passed into scatter() to force it to not modify the alpha values?

sb2nov commented Mar 14, 2012

Copy link
Copy Markdown

Cool. Thanks a lot for your help.

WeatherGod added a commit that referenced this pull request Mar 17, 2012
WeatherGod merged commit 07929d4 into matplotlib:v1.1.x Mar 17, 2012
WeatherGod deleted the mplot3d/collection_cmap_fix branch July 23, 2014 12:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL