Repository navigation
Warn on freetype missing glyphs. - #9175
Merged
tacaswell merged 1 commit intoJul 8, 2018
Merged
tacaswell merged 1 commit into
tacaswell merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
anntzer
force-pushed
the
warn-on-freetype-missing-glyphs
branch
from
c783604 to
b19fa70
Compare
April 3, 2018 05:14
There is an additional call site to FT_Get_Char_Index in PyFT2Font_get_char_index but that value is directly returned to Python so it would be easier to check for the value there and handle it accordingly (plus, in practice, the same warning will be triggered at the other two call sites at some point anyways). But I can replace that by a warning too.
anntzer
force-pushed
the
warn-on-freetype-missing-glyphs
branch
from
b19fa70 to
209b759
Compare
April 3, 2018 07:58
Copy link
Copy Markdown
Contributor
Author
|
Marking as release critical as I think it's a clear (if minor) and simple improvement. |
Sorry, something went wrong.
This was referenced Nov 6, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an additional call site to FT_Get_Char_Index in
PyFT2Font_get_char_index but that value is directly returned to Python
so it would be easier to check for the value there and handle it
accordingly (plus, in practice, the same warning will be triggered at
the other two call sites at some point anyways). But I can replace that
by a warning too.
Fixes part 3 of #8765, by triggering the warning
in the relevant case.
PR Summary
PR Checklist