Repository navigation
Revert glyph warnings - #11615
Merged
anntzer merged 2 commits intoJul 10, 2018
Merged
Revert glyph warnings#11615anntzer merged 2 commits into
anntzer merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
efiring
approved these changes
Jul 10, 2018
efiring
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It stops the warnings; the Travis failure is unrelated.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
So the culprit is where we try to get the widths of all characters in the 0-255 range regardless of whether they exist in the font or not. The correct (and faster) approach is probably to just read the max_advance_width entry in the FT_Face structure (https://www.freetype.org/freetype2/docs/reference/ft2-base_interface.html#FT_FaceRec), but I have no problem with reverting this in the meantime.Also, it would be nice to clean the warnings that occur during the test run and just make it a failure to have any warning emitted in the test suite (saying this as someone who already spammed the CI twice with repetitive warnings...). |
Sorry, something went wrong.
anntzer
approved these changes
Jul 10, 2018
2 tasks
This was referenced Nov 6, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This are producing many warnings on travis, reverting until we sort out why.