FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Demo of what pre-commit.ci looks like for the matplotlib dev team by matthewfeickert · Pull Request #9 · matthewfeickert/matplotlib · GitHub

Repository navigation

Demo of what pre-commit.ci looks like for the matplotlib dev team - #9

Closed
matthewfeickert wants to merge 24 commits into
mainfrom
demo/trigger-pre-commit-ci
Closed

matthewfeickert wants to merge 24 commits into
mainfrom
demo/trigger-pre-commit-ci

Conversation

matthewfeickert commented Apr 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Owner

This is matplotlib#22809 but on my fork.

tacaswell and others added 20 commits March 6, 2022 16:16
Co-authored-by: Greg Lucas <greg.m.lucas@gmail.com>
Co-authored-by: Greg Lucas <greg.m.lucas@gmail.com>
Looks like it was rendering as definition list due to the extra indenting.
Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com>
Fix ps export of colored hatches with no linewidth
DOC: Add links to explicit vs implicit API everywhere "OO" is used
* Update pre-commit hooks:
   - https://github.com/pre-commit/pre-commit-hooks: v4.0.1 → v4.2.0
   - https://github.com/pycqa/flake8: v3.9.2 → v4.0.1

This is being applied manually and not waiting for pre-commit.ci to
apply it as pre-commit.ci hasn't been turned on yet since these
hooks were introduced in PR 21583.
Add a git blame ignore-revs file to automatically ignore commits listed
in it from the blame view on GitHub. Include in it style changes added by
pre-commit hooks which touch multiple files.

To ignore the commits in the .git-blame-ignore-revs when running `git blame`
locally run: `git blame --ignore-revs-file .git-blame-ignore-revs`.

c.f.:
* https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt
* https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view
Add instructions to the devs on how to manually run pre-commit hooks, both for
all the hooks, and for individual hook ids. Example:
`pre-commit run flake8 --all-files`

Also use the 'python -m pip' pattern to be consistent with the rest of the docs.

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Copy link
Copy Markdown
Owner Author

pre-commit.ci autofix

Copy link
Copy Markdown
Owner Author

That was a bad example as check-docstring-first can't be autofixed. I'll try again with something like trailing-whitespace.

Copy link
Copy Markdown
Owner Author

pre-commit.ci autofix

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL