FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(claude): set milestones on issues only, never on pull requests by redfish4ktc · Pull Request #1215 · maxGraph/maxGraph · GitHub

  1. maxGraph
  2. maxGraph

Repository navigation

chore(claude): set milestones on issues only, never on pull requests - #1215

Open
redfish4ktc wants to merge 1 commit into
mainfrom
chore/claude_rule_milestones
ConversationCommits (1)ChecksFiles changed
Open

chore(claude): set milestones on issues only, never on pull requests#1215
redfish4ktc wants to merge 1 commit into
mainfrom
chore/claude_rule_milestones

Conversation

redfish4ktc commented Oct 6, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Why

A milestone tracks what a release contains, which is the issue, not the pull request implementing it. Agents tend to offer a milestone when creating a pull request, for instance when its @since tag names the version. The release process also looks for the issues closed as completed without a milestone, which only works if every fixed issue gets one: #261 was missing it, and so was the 0.5.0 milestone itself, now created.

What

  • Add the .claude/rules/git/milestones.md rule: set a milestone on issues only, never on pull requests, and give an issue fixed by a pull request the milestone of the first release containing it.
  • Reference the rule from CLAUDE.md and AGENTS.md, so that it is shared with every contributor working with an agent, whichever agent it is.

Summary by CodeRabbit

  • Documentation
    • Clarified milestone guidance: milestones are proposed for issues, not pull requests. Issues fixed by a pull request are assigned the milestone for the first release containing that pull request, regardless of when or by whom the issue is closed.
    • Added guidance for identifying missing milestones before a release.

chore(claude): set milestones on issues only, never on pull requests
b8b56b9 
A milestone tracks what a release contains, which is the issue rather than the pull request implementing it. Agents
kept offering a milestone when creating a pull request, for instance because its @SInCE tag named the version.

Add a project rule so that every contributor working with an agent gets it, and reference it from CLAUDE.md and from
AGENTS.md, which is read by the agents other than Claude Code. It also states that an issue fixed by a pull request
gets the milestone of the first release containing it, since the release process looks for the issues closed as
completed without a milestone.
redfish4ktc added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Oct 6, 2026

coderabbitai Bot commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0441d80a-20b3-4caf-b327-d4cfb7e995ca
📥 Commits

Reviewing files that changed from the base of the PR and between da790e8 and b8b56b9.

📒 Files selected for processing (3)
  • .claude/rules/git/milestones.md
  • AGENTS.md
  • CLAUDE.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The change adds guidance for proposing and assigning release milestones to issues. It specifies that milestones apply to issues, not pull requests, and describes how to assign milestones to issues fixed by a pull request.

Changes

Issue Milestone Guidance

Layer / File(s) Summary
Milestone guidance and references
.claude/rules/git/milestones.md, AGENTS.md, CLAUDE.md		 The guidance covers issue milestone proposals, assignment based on the first release containing a fixing pull request, and pre-release checks for completed issues without milestones. Repository conventions link to this guidance and state that pull requests do not receive milestones.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b8b56

This documentation change clarifies issue milestone practices and presents no actionable merge-blocking risk.

Architecture Summary

Architecture risk: 🔵 Low · up to b8b56

The change affects 2 systems.

Changed systems: AGENTS.md, CLAUDE.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — AGENTS.md (service) was modified; 1 changed file maps to changed impact.
  • observed — CLAUDE.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in AGENTS.md: The commit/PR guidance adds a milestone-conventions reference and specifies that milestones are for issues, never PRs.
  • observed — Modified behavior in CLAUDE.md: Adds a link to the milestone-setting guidance, noting it applies to issues and not pull requests.
  • observed — Modified behavior in .claude/rules/git/milestones.md: Added guidance to assign release milestones to issues, not pull requests; propose issue milestones alongside labels and issue type, and assign fixed issues the first release containing their fixing pull request. It also describes the pre-release check for completed issues missing milestones.
🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the change: milestones apply to issues, not pull requests. It is concise and follows the repository’s Conventional Commits format.
Description check ✅ Passed The description explains why the change is needed and what it changes, including the new milestone guidance and its references in CLAUDE.md and AGENTS.md. It does not include the template’s checklist …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

sonarqubecloud Bot commented Oct 6, 2026

Copy link
Copy Markdown

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL