FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(claude): set milestones on issues only, never on pull requests by redfish4ktc · Pull Request #1215 · maxGraph/maxGraph · GitHub

  1. maxGraph
  2. maxGraph

Repository navigation

chore(claude): set milestones on issues only, never on pull requests #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
redfish4ktc wants to merge 1 commit into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 2 Commits 1 Checks 5 Files changed
Open

chore(claude): set milestones on issues only, never on pull requests #1215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .md  (3) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
20 changes: 20 additions & 0 deletions .claude/rules/git/milestones.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Milestones

Applies whenever an issue or a pull request is created or edited, for instance with `gh issue create`,
`gh issue edit` or `gh pr create`.

## Set a milestone on issues only, never on pull requests

A milestone is named after the version it ships in, such as `0.26.0`, and tracks what that release contains. That is
the work item, so it belongs to the issue. The pull request implementing it is only the change, and the issue it closes
already carries the release.

- When creating or editing an issue, propose a milestone along with the labels and the issue type.
- When creating or editing a pull request, set labels only, and do not offer a milestone, even when the branch clearly
targets a given release or adds a `@since` tag naming its version.
- An issue fixed by a pull request gets the milestone of the first release containing that pull request, also when the
issue is closed long after, or by its author.

The release process relies on it: before a release, the maintainer looks for the issues closed as completed without a
milestone, so a missing one shows up there, see the
[release how-to](../../../packages/website/docs/development/release.md).
2 changes: 1 addition & 1 deletion AGENTS.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ This document provides essential knowledge for AI coding agents to be productive
- **Mixins/Plugins**: Add new features via mixins or plugins, not by modifying core classes directly.
- **Registries**: Register only required shapes/styles for tree-shaking (see `ts-example-selected-features`).
- **Testing**: Use Jest. Test patterns in `.claude/rules/testing/conventions.md`.
- **Commits/PRs**: Follow `.claude/rules/git/commit-conventions.md` for commit messages and `.claude/rules/git/pull-requests.md` when updating a PR description. PRs should run full CI.
- **Commits/PRs**: Follow `.claude/rules/git/commit-conventions.md` for commit messages, `.claude/rules/git/pull-requests.md` when updating a PR description, and `.claude/rules/git/milestones.md` before setting a milestone (issues only, never PRs). PRs should run full CI.
- **Documentation**: Update `README.md` and `CLAUDE.md` for major changes. Use concise, accurate docs.

### 4. Examples & Integration
Expand Down
1 change: 1 addition & 0 deletions CLAUDE.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ Key patterns:
- See `.claude/rules/documentation/guides-structure.md` for the structure of the website guides (prerequisites, titles)
- See `.claude/rules/git/commit-conventions.md` for commit message style
- See `.claude/rules/git/pull-requests.md` for updating a pull request description (keep the blocks added by bots)
- See `.claude/rules/git/milestones.md` before setting a milestone (issues only, never pull requests)

## References

Expand Down
Loading
Back | FazBrowse Home | New Git URL