ci(publish): diagnose playwright install hang — verbose env + 10min timeout - #1496
Merged
obiot merged 1 commit intoJun 8, 2026
Merged
ci(publish): diagnose playwright install hang — verbose env + 10min timeout#1496obiot merged 1 commit into
obiot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…imeout The last five `publish.yml` runs all hung indefinitely on the "Install Playwright browsers" step. Logs show the chromium binary downloads cleanly in ~0.5s then ~51 minutes of dead silence before manual cancel. So the hang is on a post-download step (extract / validate / spawn), not the CDN. Two minimal observability tweaks so the next attempt gives us actionable evidence instead of another black-box hang: - **`DEBUG: pw:install`** — Playwright's install-namespace debug-logger emits a line per stage (verify, extract, write marker, etc.). Should surface exactly where the silence starts. - **`timeout-minutes: 10`** — caps the step at ~10 min so a hung install fails fast and frees the runner instead of burning the 6-hour job budget. Healthy installs land in 2-3 min, so 10 leaves ample headroom. Pure diagnostic / safety. No behaviour change on a healthy run. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
obiot
added a commit
that referenced
this pull request
Jun 8, 2026
… publish.yml (#1497) Two related cleanups: 1. **main.yml now runs ALL package tests**, not just melonjs. The adapter test specs (3 × matter, 3 × planck) existed but were only invoked at publish time — meaning PR merges never gated on them. The new `pnpm -F @melonjs/{matter,planck}-adapter test` lines run inside the same `mcr.microsoft.com/playwright:v1.59.1-noble` container the existing melonjs test job uses, so chromium is pre-baked, no install step needed. 2. **publish.yml stops re-running tests** that main.yml now gates: - Drop the `Install Playwright browsers` step entirely (no tests at publish time → no chromium needed). - melonjs `pnpm dist` (`clean + lint + vitest + build + doc`) is replaced with new `pnpm dist:publish` (drops `vitest`). - matter / planck build_cmd drops the trailing `&& pnpm test`. This also sidesteps a real Playwright bug we've been hitting all day: on bare `ubuntu-latest` runners, `playwright install chromium` was hanging indefinitely on the post-download extract step (download itself completes in <2s; extract emits no further log line and times out the entire job). Six consecutive runs hit the same hang on distinct runners. Identified via the `DEBUG: pw:install` + `timeout-minutes: 10` instrumentation from #1496. Sidestepping the install entirely is the cleanest fix and aligns with main.yml's container-based approach anyway. Local verify: - `pnpm -F @melonjs/matter-adapter test` → 177 / 177 pass - `pnpm -F @melonjs/planck-adapter test` → 169 / 169 pass - `pnpm dist:publish` → clean exit, docs generated Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last five `publish.yml` runs all hung indefinitely on the Install Playwright browsers step. Logs show the chromium binary downloads cleanly in ~0.5s and then ~51 minutes of dead silence before manual cancel. So the hang is on a post-download step (extract / validate / spawn), not the CDN. Direct downloads from playwright.dev outside the runner work fine.
Two minimal observability tweaks so the next attempt gives us actionable evidence instead of another black-box hang:
Pure diagnostic / safety. No behaviour change on a healthy run; visibly faster failure on a sick one.
Once the next dispatch fails with verbose output, we'll know what the real fix is — likely a Playwright version pin, a sandbox flag, or a missing apt package.
Test plan
🤖 Generated with Claude Code