Support targeting context accessor - #93
Merged
Zhiyuan Liang (zhiyuanliang-ms) merged 11 commits intoMar 26, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Zhiyuan Liang (zhiyuanliang-ms)
requested review from
Copilot and
linglingye001
February 6, 2025 08:12
Copy link
Copy Markdown
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)- src/feature-management/package-lock.json: Language not supported
- src/feature-management/src/filter/TargetingFilter.ts: Evaluated as low risk
Sorry, something went wrong.
Comment thread
src/feature-management/src/IFeatureManager.ts
Comment thread
src/feature-management/src/common/targetingContext.ts
Outdated
Comment thread
src/feature-management/src/featureManager.ts
Outdated
Comment thread
src/feature-management/src/featureManager.ts
Outdated
Closed
Comment thread
src/feature-management/src/featureManager.ts
Outdated
Comment thread
src/feature-management/src/featureManager.ts
Outdated
Comment thread
src/feature-management/src/common/targetingContext.ts
…ent-JavaScript into zhiyuanliang/targeting-context-accessor
Ross Grambo (rossgrambo)
approved these changes
Mar 25, 2025
Comment thread
src/feature-management/src/featureManager.ts
Zhiyuan Liang (zhiyuanliang-ms)
deleted the
zhiyuanliang/targeting-context-accessor
branch
March 26, 2025 02:39
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR?
#55
Support targeting context accessor pattern, align with other FM libraries
Usage
An example application can be found #105
If targeting context is explicitly provided within isEnabled or getVariant call, it will have the higher priority than the targeting context accessor. See the testcases and comment