FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support telemetry processor & initializer by zhiyuanliang-ms · Pull Request #98 · microsoft/FeatureManagement-JavaScript · GitHub

/ FeatureManagement-JavaScript Public

Support telemetry processor & initializer - #98

Merged
Zhiyuan Liang (zhiyuanliang-ms) merged 12 commits into
previewfrom
zhiyuanliang/telemetry-processor
Apr 21, 2025
ConversationCommits (12)ChecksFiles changed
Merged

Support telemetry processor & initializer#98
Zhiyuan Liang (zhiyuanliang-ms) merged 12 commits into
previewfrom
zhiyuanliang/telemetry-processor

Conversation

Zhiyuan Liang (zhiyuanliang-ms) commented Feb 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Why this PR?

This PR is based on the targeting context accessor PR: #93

Support automatically attaching targeting id to telemetry like request, dependency which are collected automatically by app insights

Similar to the exisiting pattern

Usage

Node

const { createTargetingTelemetryProcessor } = require("@microsoft/feature-management-applicationinsights-node");
const myTargetingProcessor = createTargetingTelemetryProcessor(myTargetingContextAccessor);
appInsights.defaultClient.addTelemetryProcessor(myTargetingProcessor);

Browser

const { createTargetingTelemetryInitializer } = require("@microsoft/feature-management-applicationinsights-browser");
const myTargetingInitializer = createTargetingTelemetryInitializer(myTargetingContextAccessor);
appInsights.addTelemetryInitializer(attachTargetingId);

Reference

Classic Application Insights v2 SDK for Node: doc
Application Insights SDK for browser: doc
POC

Zhiyuan Liang (zhiyuanliang-ms) changed the base branch from main to zhiyuanliang/targeting-context-accessor February 10, 2025 11:14
Copilot AI reviewed Feb 10, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot reviewed 5 out of 17 changed files in this pull request and generated no comments.

Files not reviewed (12)
  • src/feature-management-applicationinsights-browser/package.json: Language not supported
  • src/feature-management-applicationinsights-node/package.json: Language not supported
  • src/feature-management/package-lock.json: Language not supported
  • src/feature-management/package.json: Language not supported
  • src/feature-management/src/common/ITargetingContext.ts: Evaluated as low risk
  • src/feature-management/src/filter/TargetingFilter.ts: Evaluated as low risk
  • src/feature-management/src/index.ts: Evaluated as low risk
  • src/feature-management/src/IFeatureManager.ts: Evaluated as low risk
  • src/feature-management-applicationinsights-node/src/index.ts: Evaluated as low risk
  • src/feature-management/src/featureManager.ts: Evaluated as low risk
  • src/feature-management-applicationinsights-browser/src/index.ts: Evaluated as low risk
  • src/feature-management/test/targetingFilter.test.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/feature-management-applicationinsights-node/src/telemetry.ts:52

  • The warning message 'Targeting id is undefined.' is unclear. Consider changing it to 'TargetingContextAccessor returned undefined userId.' to provide more context.
console.warn("Targeting id is undefined.");

Ross Grambo (rossgrambo) commented Mar 25, 2025

Copy link
Copy Markdown

I imagine this PR needs to pull the updates from the other PR

Base automatically changed from zhiyuanliang/targeting-context-accessor to preview March 26, 2025 02:39
Ross Grambo (rossgrambo) previously approved these changes Apr 17, 2025
View reviewed changes
Comment thread src/feature-management-applicationinsights-node/src/telemetry.ts Outdated
Zhiyuan Liang (zhiyuanliang-ms) deleted the zhiyuanliang/telemetry-processor branch April 21, 2025 09:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
Shi Chen (CsCherrYY) CsCherrYY approved these changes
Matthew Metcalf (mrm9084) Awaiting requested review from mrm9084
Jimmy Campbell (jimmyca15) Awaiting requested review from jimmyca15
linglingye001 Awaiting requested review from linglingye001
+1 more reviewer
Ross Grambo (rossgrambo) rossgrambo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL