FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert 'awaited' type by rbuckton · Pull Request #37610 · microsoft/TypeScript · GitHub

/ TypeScript Public

Revert 'awaited' type - #37610

Merged
Ron Buckton (rbuckton) merged 1 commit into
masterfrom
revertAwaitedType
Mar 26, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Revert 'awaited' type#37610
Ron Buckton (rbuckton) merged 1 commit into
masterfrom
revertAwaitedType

Conversation

Ron Buckton (rbuckton) commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

The new awaited type is currently causing too many breaks to be considered stable for TS 3.9. This PR reverts the awaited type for this release while we continue to investigate the impact of the change.

Closes #37511
Closes #37512
Closes #37526
Closes #37528
Closes #37534
Closes #37551
Closes #37556
Closes #37564
Closes #37566
Closes #37567
Closes #37572
Closes #37592
Closes #37602
Closes #37603

Ron Buckton (rbuckton) commented Mar 25, 2020

Copy link
Copy Markdown
Contributor Author

TypeScript Bot (@typescript-bot) perf test
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this

TypeScript Bot (typescript-bot) commented Mar 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ron Buckton (@rbuckton), I've started to run the perf test suite on this PR at a638aa8. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) commented Mar 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ron Buckton (@rbuckton), I've started to run the parallelized Definitely Typed test suite on this PR at a638aa8. You can monitor the build here.

TypeScript Bot (typescript-bot) commented Mar 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ron Buckton (@rbuckton), I've started to run the extended test suite on this PR at a638aa8. You can monitor the build here.

TypeScript Bot (typescript-bot) commented Mar 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ron Buckton (@rbuckton), I've started to run the parallelized community code test suite on this PR at a638aa8. You can monitor the build here.

This was referenced Mar 25, 2020
Closed
Closed
Nathan Shively-Sanders (sandersn) approved these changes Mar 25, 2020
View reviewed changes

Nathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks reasonable to me.

Open

TypeScript Bot (typescript-bot) commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

TypeScript Bot (typescript-bot) commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

Ron Buckton (@rbuckton)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..37610

Metric master 37610 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 327,718k (± 0.02%) 326,933k (± 0.04%) -786k (- 0.24%) 326,512k 327,111k
Parse Time 1.63s (± 0.58%) 1.61s (± 0.51%) -0.01s (- 0.80%) 1.60s 1.64s
Bind Time 0.89s (± 1.01%) 0.88s (± 0.96%) -0.00s (- 0.56%) 0.86s 0.90s
Check Time 4.78s (± 0.48%) 4.75s (± 0.51%) -0.03s (- 0.57%) 4.68s 4.81s
Emit Time 5.32s (± 0.88%) 5.31s (± 0.47%) -0.02s (- 0.30%) 5.27s 5.37s
Total Time 12.61s (± 0.55%) 12.55s (± 0.35%) -0.06s (- 0.50%) 12.44s 12.62s
Monaco - node (v10.16.3, x64)
Memory used 327,135k (± 0.02%) 327,078k (± 0.02%) -57k (- 0.02%) 326,936k 327,296k
Parse Time 1.25s (± 0.61%) 1.25s (± 0.29%) -0.00s (- 0.08%) 1.25s 1.26s
Bind Time 0.77s (± 0.58%) 0.77s (± 0.44%) +0.00s (+ 0.13%) 0.77s 0.78s
Check Time 4.73s (± 0.26%) 4.74s (± 0.62%) +0.01s (+ 0.11%) 4.67s 4.80s
Emit Time 2.92s (± 0.71%) 2.91s (± 0.50%) -0.01s (- 0.48%) 2.87s 2.94s
Total Time 9.69s (± 0.22%) 9.68s (± 0.36%) -0.01s (- 0.10%) 9.61s 9.75s
TFS - node (v10.16.3, x64)
Memory used 291,963k (± 0.02%) 291,993k (± 0.03%) +30k (+ 0.01%) 291,878k 292,172k
Parse Time 0.95s (± 0.47%) 0.95s (± 0.38%) -0.01s (- 0.63%) 0.94s 0.95s
Bind Time 0.75s (± 0.80%) 0.74s (± 0.66%) -0.00s (- 0.27%) 0.73s 0.75s
Check Time 4.26s (± 0.58%) 4.26s (± 0.29%) +0.00s (+ 0.05%) 4.24s 4.28s
Emit Time 3.06s (± 0.36%) 3.05s (± 0.80%) -0.01s (- 0.46%) 3.00s 3.09s
Total Time 9.02s (± 0.28%) 9.00s (± 0.27%) -0.01s (- 0.16%) 8.94s 9.05s
material-ui - node (v10.16.3, x64)
Memory used 452,881k (± 0.01%) 452,579k (± 0.01%) -302k (- 0.07%) 452,488k 452,666k
Parse Time 1.77s (± 0.31%) 1.77s (± 0.37%) 0.00s ( 0.00%) 1.76s 1.79s
Bind Time 0.68s (± 0.77%) 0.68s (± 0.59%) 0.00s ( 0.00%) 0.67s 0.69s
Check Time 13.66s (± 0.69%) 13.60s (± 0.56%) -0.06s (- 0.43%) 13.42s 13.76s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.11s (± 0.59%) 16.06s (± 0.46%) -0.06s (- 0.37%) 15.88s 16.21s
Angular - node (v12.1.0, x64)
Memory used 303,414k (± 0.03%) 302,662k (± 0.08%) -752k (- 0.25%) 301,675k 302,946k
Parse Time 1.58s (± 0.56%) 1.57s (± 0.41%) -0.01s (- 0.32%) 1.56s 1.59s
Bind Time 0.87s (± 0.83%) 0.87s (± 0.68%) +0.00s (+ 0.23%) 0.86s 0.89s
Check Time 4.64s (± 0.45%) 4.64s (± 1.05%) +0.00s (+ 0.02%) 4.58s 4.83s
Emit Time 5.47s (± 0.46%) 5.48s (± 1.00%) +0.01s (+ 0.13%) 5.39s 5.67s
Total Time 12.56s (± 0.26%) 12.57s (± 0.78%) +0.00s (+ 0.04%) 12.46s 12.94s
Monaco - node (v12.1.0, x64)
Memory used 307,099k (± 0.02%) 307,015k (± 0.02%) -83k (- 0.03%) 306,795k 307,128k
Parse Time 1.20s (± 0.62%) 1.20s (± 0.49%) +0.00s (+ 0.33%) 1.19s 1.22s
Bind Time 0.75s (± 1.02%) 0.74s (± 0.92%) -0.01s (- 1.21%) 0.73s 0.76s
Check Time 4.56s (± 0.22%) 4.55s (± 0.45%) -0.00s (- 0.04%) 4.53s 4.61s
Emit Time 2.96s (± 0.49%) 2.95s (± 0.47%) -0.01s (- 0.30%) 2.92s 2.97s
Total Time 9.46s (± 0.20%) 9.45s (± 0.28%) -0.01s (- 0.13%) 9.38s 9.49s
TFS - node (v12.1.0, x64)
Memory used 274,292k (± 0.03%) 274,307k (± 0.02%) +15k (+ 0.01%) 274,166k 274,404k
Parse Time 0.93s (± 0.51%) 0.93s (± 0.48%) -0.00s (- 0.11%) 0.92s 0.94s
Bind Time 0.70s (± 1.23%) 0.70s (± 1.18%) +0.00s (+ 0.43%) 0.69s 0.73s
Check Time 4.17s (± 0.43%) 4.19s (± 0.48%) +0.02s (+ 0.41%) 4.14s 4.23s
Emit Time 3.10s (± 1.10%) 3.09s (± 0.99%) -0.01s (- 0.45%) 3.02s 3.16s
Total Time 8.91s (± 0.43%) 8.91s (± 0.47%) +0.00s (+ 0.01%) 8.84s 9.01s
material-ui - node (v12.1.0, x64)
Memory used 430,291k (± 0.01%) 429,928k (± 0.05%) -364k (- 0.08%) 429,033k 430,241k
Parse Time 1.75s (± 0.40%) 1.75s (± 0.33%) +0.00s (+ 0.06%) 1.74s 1.76s
Bind Time 0.63s (± 0.75%) 0.63s (± 1.02%) +0.00s (+ 0.32%) 0.62s 0.65s
Check Time 12.15s (± 0.55%) 12.10s (± 0.29%) -0.05s (- 0.41%) 12.04s 12.20s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.53s (± 0.42%) 14.48s (± 0.26%) -0.05s (- 0.35%) 14.40s 14.58s
Angular - node (v8.9.0, x64)
Memory used 322,812k (± 0.02%) 322,061k (± 0.01%) -752k (- 0.23%) 321,957k 322,166k
Parse Time 2.12s (± 0.21%) 2.10s (± 0.33%) -0.01s (- 0.61%) 2.09s 2.12s
Bind Time 0.91s (± 0.37%) 0.92s (± 0.79%) +0.00s (+ 0.55%) 0.91s 0.94s
Check Time 5.48s (± 1.18%) 5.43s (± 1.06%) -0.05s (- 0.91%) 5.26s 5.51s
Emit Time 6.24s (± 1.95%) 6.26s (± 1.28%) +0.02s (+ 0.40%) 6.14s 6.54s
Total Time 14.75s (± 0.72%) 14.71s (± 0.33%) -0.03s (- 0.22%) 14.59s 14.85s
Monaco - node (v8.9.0, x64)
Memory used 325,482k (± 0.01%) 325,498k (± 0.01%) +16k (+ 0.00%) 325,424k 325,593k
Parse Time 1.55s (± 0.44%) 1.54s (± 0.43%) -0.00s (- 0.19%) 1.53s 1.56s
Bind Time 0.89s (± 0.38%) 0.89s (± 0.58%) -0.00s (- 0.45%) 0.88s 0.90s
Check Time 5.35s (± 0.65%) 5.37s (± 0.43%) +0.01s (+ 0.21%) 5.32s 5.42s
Emit Time 3.51s (± 0.72%) 3.50s (± 0.36%) -0.01s (- 0.31%) 3.48s 3.53s
Total Time 11.30s (± 0.47%) 11.30s (± 0.24%) -0.00s (- 0.03%) 11.25s 11.35s
TFS - node (v8.9.0, x64)
Memory used 291,358k (± 0.02%) 291,365k (± 0.01%) +7k (+ 0.00%) 291,275k 291,419k
Parse Time 1.25s (± 0.47%) 1.26s (± 0.47%) +0.00s (+ 0.16%) 1.24s 1.27s
Bind Time 0.75s (± 0.64%) 0.74s (± 0.63%) -0.01s (- 0.94%) 0.73s 0.75s
Check Time 4.88s (± 1.27%) 4.86s (± 1.90%) -0.02s (- 0.47%) 4.74s 5.12s
Emit Time 3.31s (± 2.11%) 3.29s (± 1.51%) -0.02s (- 0.48%) 3.15s 3.36s
Total Time 10.19s (± 0.39%) 10.15s (± 0.51%) -0.04s (- 0.39%) 10.05s 10.31s
material-ui - node (v8.9.0, x64)
Memory used 455,455k (± 0.01%) 455,141k (± 0.01%) -313k (- 0.07%) 455,022k 455,220k
Parse Time 2.11s (± 0.72%) 2.10s (± 0.53%) -0.00s (- 0.14%) 2.08s 2.13s
Bind Time 0.81s (± 1.03%) 0.81s (± 1.19%) +0.00s (+ 0.37%) 0.79s 0.83s
Check Time 17.64s (± 0.62%) 17.65s (± 0.38%) +0.01s (+ 0.09%) 17.52s 17.83s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 20.55s (± 0.59%) 20.56s (± 0.36%) +0.02s (+ 0.08%) 20.43s 20.77s
Angular - node (v8.9.0, x86)
Memory used 185,749k (± 0.02%) 185,365k (± 0.03%) -385k (- 0.21%) 185,244k 185,519k
Parse Time 2.05s (± 0.35%) 2.06s (± 0.84%) +0.01s (+ 0.24%) 2.03s 2.11s
Bind Time 1.07s (± 0.52%) 1.07s (± 0.35%) -0.00s (- 0.28%) 1.06s 1.07s
Check Time 4.99s (± 0.59%) 4.99s (± 0.32%) -0.00s (- 0.02%) 4.95s 5.03s
Emit Time 6.06s (± 0.44%) 6.03s (± 0.68%) -0.03s (- 0.49%) 5.97s 6.14s
Total Time 14.17s (± 0.35%) 14.15s (± 0.45%) -0.02s (- 0.17%) 14.04s 14.31s
Monaco - node (v8.9.0, x86)
Memory used 185,276k (± 0.02%) 185,251k (± 0.02%) -24k (- 0.01%) 185,185k 185,330k
Parse Time 1.59s (± 0.76%) 1.61s (± 1.19%) +0.01s (+ 0.75%) 1.57s 1.66s
Bind Time 0.76s (± 0.58%) 0.77s (± 1.22%) +0.01s (+ 1.05%) 0.75s 0.79s
Check Time 5.39s (± 0.44%) 5.41s (± 0.68%) +0.02s (+ 0.32%) 5.34s 5.49s
Emit Time 2.86s (± 0.83%) 2.89s (± 1.28%) +0.03s (+ 1.05%) 2.81s 3.00s
Total Time 10.61s (± 0.42%) 10.68s (± 0.76%) +0.07s (+ 0.69%) 10.53s 10.91s
TFS - node (v8.9.0, x86)
Memory used 166,797k (± 0.02%) 166,763k (± 0.02%) -34k (- 0.02%) 166,687k 166,877k
Parse Time 1.29s (± 0.60%) 1.28s (± 0.38%) -0.01s (- 0.39%) 1.27s 1.29s
Bind Time 0.71s (± 0.70%) 0.71s (± 0.81%) -0.01s (- 0.70%) 0.70s 0.72s
Check Time 4.61s (± 0.64%) 4.60s (± 0.54%) -0.01s (- 0.20%) 4.55s 4.66s
Emit Time 2.99s (± 1.06%) 2.96s (± 1.08%) -0.03s (- 1.14%) 2.89s 3.01s
Total Time 9.60s (± 0.44%) 9.55s (± 0.44%) -0.05s (- 0.54%) 9.46s 9.63s
material-ui - node (v8.9.0, x86)
Memory used 257,642k (± 0.02%) 257,423k (± 0.01%) -219k (- 0.08%) 257,369k 257,517k
Parse Time 2.19s (± 0.70%) 2.18s (± 0.57%) -0.01s (- 0.32%) 2.14s 2.19s
Bind Time 0.68s (± 1.37%) 0.68s (± 1.20%) +0.00s (+ 0.29%) 0.66s 0.70s
Check Time 16.26s (± 0.87%) 16.19s (± 0.44%) -0.07s (- 0.44%) 16.10s 16.41s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 19.12s (± 0.75%) 19.05s (± 0.40%) -0.07s (- 0.39%) 18.96s 19.30s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 37610 10
Baseline master 10

Ron Buckton (rbuckton) commented Mar 25, 2020

Copy link
Copy Markdown
Contributor Author

I found a few more stragglers, will update shortly.

Ron Buckton (rbuckton) commented Mar 25, 2020

Copy link
Copy Markdown
Contributor Author

TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this

TypeScript Bot (typescript-bot) commented Mar 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ron Buckton (@rbuckton), I've started to run the extended test suite on this PR at 28946c3. You can monitor the build here.

TypeScript Bot (typescript-bot) commented Mar 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ron Buckton (@rbuckton), I've started to run the parallelized community code test suite on this PR at 28946c3. You can monitor the build here.

TypeScript Bot (typescript-bot) commented Mar 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ron Buckton (@rbuckton), I've started to run the parallelized Definitely Typed test suite on this PR at 28946c3. You can monitor the build here.

This was referenced Mar 25, 2020
Closed
Closed

Ron Buckton (rbuckton) commented Mar 26, 2020

Copy link
Copy Markdown
Contributor Author

TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this

TypeScript Bot (typescript-bot) commented Mar 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ron Buckton (@rbuckton), I've started to run the parallelized Definitely Typed test suite on this PR at 5017cb8. You can monitor the build here.

TypeScript Bot (typescript-bot) commented Mar 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ron Buckton (@rbuckton), I've started to run the parallelized community code test suite on this PR at 5017cb8. You can monitor the build here.

TypeScript Bot (typescript-bot) commented Mar 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ron Buckton (@rbuckton), I've started to run the extended test suite on this PR at 5017cb8. You can monitor the build here.

Ron Buckton (rbuckton) commented Mar 26, 2020

Copy link
Copy Markdown
Contributor Author

Ron Buckton (rbuckton) merged commit 4fc4c4e into master Mar 26, 2020

Ron Buckton (rbuckton) commented Mar 26, 2020

Copy link
Copy Markdown
Contributor Author

TypeScript Bot (@typescript-bot) cherry-pick this to release-3.9

TypeScript Bot (typescript-bot) commented Mar 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ron Buckton (@rbuckton), I've started to run the task to cherry-pick this into release-3.9 on this PR at 5017cb8. You can monitor the build here.

Merged

TypeScript Bot (typescript-bot) commented Mar 26, 2020

Copy link
Copy Markdown
Contributor

Hey Ron Buckton (@rbuckton), I've opened #37614 for you.

TypeScript Bot (typescript-bot) pushed a commit to typescript-bot/TypeScript that referenced this pull request Mar 26, 2020
Cherry-pick PR microsoft#37610 into release-3.9
a0ef598 
Component commits:
5017cb8 Revert 'awaited' type
Ron Buckton (rbuckton) added a commit that referenced this pull request Mar 26, 2020
Cherry-pick PR #37610 into release-3.9 (#37614)
859f4c1 
Component commits:
5017cb8 Revert 'awaited' type

Co-authored-by: Ron Buckton <rbuckton@microsoft.com>
This was referenced Mar 26, 2020
Merged
Merged
Merged
Merged

Benjamin Vincent (Luxcium) commented Mar 27, 2020

Copy link
Copy Markdown

oops... I was relying on this solution because I have a Promise<MaybeList<Promise<ISymbolSearchResult[]>>>
where MaybeList is an array abstraction so I am using promise.all to remove the inner Promise I don't know what to do now to avoid using as unknown as MaybeList<ISymbolSearchResult[]> inside of my async function (which should be returning the Promise<MaybeList<ISymbolSearchResult[]>> instead of the Promise<MaybeList<Promise<ISymbolSearchResult[]>>>)

This was referenced Mar 27, 2020
Closed
Closed
Closed
Open
Closed
Andrew Casey (amcasey) mentioned this pull request Apr 1, 2020
Merged
1 task
Ron Buckton (rbuckton) mentioned this pull request Dec 16, 2020
Closed
Jake Bailey (jakebailey) deleted the revertAwaitedType branch November 7, 2022 17:36
Wesley Wigham (weswigham) mentioned this pull request Mar 11, 2024
Merged
Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Back | FazBrowse Home | New Git URL