馃 User test baselines have changed for revertAwaitedType - #11
Open
typescript-bot wants to merge 2 commits into
Open
馃 User test baselines have changed for revertAwaitedType#11typescript-bot wants to merge 2 commits into
typescript-bot wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
typescript-bot
force-pushed
the
user-baseline-updates
branch
2 times, most recently
from
c9e477b to
75cbaff
Compare
March 25, 2020 23:29
typescript-bot
force-pushed
the
user-baseline-updates
branch
from
75cbaff to
22e1ca7
Compare
March 26, 2020 00:03
typescript-bot
force-pushed
the
user-update-microsoft--revertAwaitedType
branch
from
2167776 to
06ea5a4
Compare
March 26, 2020 00:04
typescript-bot
force-pushed
the
user-update-microsoft--revertAwaitedType
branch
from
06ea5a4 to
102ca07
Compare
March 26, 2020 01:21
rbuckton
reviewed
Mar 26, 2020
Comment thread
tests/baselines/reference/docker/vscode.log
| Type 'awaited U' is not assignable to type 'U'. | ||
| 'U' could be instantiated with an arbitrary type which could be unrelated to 'awaited U'. | ||
| [XX:XX:XX] Error: /vscode/src/vs/workbench/contrib/search/common/searchModel.ts(609,21): Type 'FileMatch | FileMatch[]' must have a '[Symbol.iterator]()' method that returns an iterator. | ||
| [XX:XX:XX] Error: /vscode/src/vs/base/browser/ui/tree/asyncDataTree.ts(215,2): Type '{ collapseByDefault: true; identityProvider: { getId(el: IAsyncDataTreeNode<TInput, T>): { toString(): string; }; } | undefined; dnd: AsyncDataTreeNodeListDragAndDrop<TInput, T> | undefined; ... 31 more ...; horizontalScrolling?: boolean | undefined; } | undefined' is not assignable to type 'IObjectTreeOptions<IAsyncDataTreeNode<TInput, T>, TFilterData> | undefined'. |
Copy link
Copy Markdown
There was a problem hiding this comment.
This looks to actually be due to microsoft#36539
Sorry, something went wrong.
typescript-bot
force-pushed
the
user-baseline-updates
branch
21 times, most recently
from
7f3dced to
fc14de5
Compare
March 30, 2020 22:50
typescript-bot
force-pushed
the
user-baseline-updates
branch
30 times, most recently
from
70f9a07 to
06e1381
Compare
April 7, 2020 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on microsoft#37610
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @rbuckton