Ensure resolved signature is cached before processing call errors - #49598
Ensure resolved signature is cached before processing call errors#49598Jake Bailey (jakebailey) merged 4 commits into
Conversation
Sorry, something went wrong.
|
TypeScript Bot (@typescript-bot) test this |
Sorry, something went wrong.
|
Heya Jake Bailey (@jakebailey), I've started to run the extended test suite on this PR at a65ebb2. You can monitor the build here. |
Sorry, something went wrong.
|
Heya Jake Bailey (@jakebailey), I've started to run the parallelized Definitely Typed test suite on this PR at a65ebb2. You can monitor the build here. |
Sorry, something went wrong.
|
Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at a65ebb2. You can monitor the build here. Update: The results are in! |
Sorry, something went wrong.
|
Jake Bailey (@jakebailey) |
Sorry, something went wrong.
|
Heya Jake Bailey (@jakebailey), I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
Sorry, something went wrong.
|
RWC shows one change, and it looks to me like an extra error that shouldn't have been there in the first place (an assignment error where it complains both on the right side, then again on the left side about the same thing), so that seems good. |
Sorry, something went wrong.
nievesmiguel
left a comment
There was a problem hiding this comment.
``
Sorry, something went wrong.
Fixes #48636
Big thanks to Wesley Wigham (@weswigham) for sitting with me for 2 hours to debug this.
I couldn't move the caching code from resolvedSignature down into resolveCall; getResolvedSignature conditionally sets resolvedSignature before calling resolveSignature, and resolveSignature then calls a bunch of other functions which do other things before actually resolving the signature. If I move this caching downward where it seems like it should be, I break enough tests to crash the test host.