| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
| BaseClass extends new (...args: any[]) => any, | ||
| >(Base: BaseClass): any; | ||
|
|
||
| declare class Item extends ClientDocumentMixin(BaseItem) {} |
There was a problem hiding this comment.
due to the circular nature of this example, the compiler goes into resolveCall for the same node twice in a nested manner
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks a ton for this PR and the explanation! It makes the crash make much more sense to me now.
I will say some of these steps still seem to have a bit of concerning logic and seem to help explain something else weird I noted on my issue, namely that there doesn't have to be a "real" loop in the base type for you to get an error like Argument of type 'typeof BaseItem' is not assignable to parameter of type 'new (...args: any[]) => any'.
Playground (make sure to make any edit to overcome the crash and view an error!)
Sorry, something went wrong.
There was a problem hiding this comment.
tbh your example is somewhat convoluted to the point that I'm not sure if it should error or not. It's definitely outside of the "regular TS" territory 😅 so all I was after here was to fix the crash. Once this gets fixed you might want to raise a new issue about the circularity issue if you thing it shouldn't be reported
Sorry, something went wrong.
|
TypeScript Bot (@typescript-bot) test it |
Sorry, something went wrong.
|
Starting jobs; this comment will be updated as builds start and complete.
|
Sorry, something went wrong.
|
Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready. Everything looks the same! |
Sorry, something went wrong.
|
Jake Bailey (@jakebailey) Here are the results of running the user tests with tsc comparing main and refs/pull/60208/merge: Everything looks good! |
Sorry, something went wrong.
|
Jake Bailey (@jakebailey)
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sorry, something went wrong.
|
Jake Bailey (@jakebailey) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60208/merge: Everything looks good! |
Sorry, something went wrong.
There was a problem hiding this comment.
Seems like a promising idea in the absence of the possibility of fixing the assignability result inconsistency, but I left a question.
Sorry, something went wrong.
There was a problem hiding this comment.
Left a question.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
fixes #60202
cc Gabriela Araujo Britto (@gabritto)