Ban import=require and export= under erasableSyntaxOnly - #61175
Jake Bailey (jakebailey) merged 2 commits into
Conversation
Sorry, something went wrong.
| return MyClassOk; | ||
| }()); | ||
| //// [commonjs.cjs] | ||
| "use strict"; |
There was a problem hiding this comment.
Oh no, this means that CJS isn't even erasable because we assume strict and always insert it
Sorry, something went wrong.
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-5.8 |
Sorry, something went wrong.
|
Starting jobs; this comment will be updated as builds start and complete.
|
Sorry, something went wrong.
|
Hey, Jake Bailey (@jakebailey)! I've created #61178 for you. |
Sorry, something went wrong.
|
Jake Bailey (@jakebailey) was this intended to affect exports when using "type": "module"? |
Sorry, something went wrong.
|
No, definitely not. I forgot that default exports and export= are the same node. |
Sorry, something went wrong.
|
Merged, so should be fixed in the next nightly. I'm glad at least one person is testing them... |
Sorry, something went wrong.
…e-5.8 (#61178) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Per discussion; this syntax isn't supported by Node.js/Amaro or ts-blank-space, and export= is not actually erasable as its transformed syntax is module.exports=.
This effectively means you can't write any CJS code under erasableSyntaxOnly (without using const foo = require("foo") and module.exports = ... directly, which do not bind in TS). Perhaps we can make const foo = require("...") and module.exports = ... bind like they do in JS for TS files in the future.
Updates #59601
Updates #61011