Fix mistakenly disallowed default export under erasableSyntaxOnly - #61210
Merged
Jake Bailey (jakebailey) merged 3 commits intoFeb 18, 2025
Merged
Jake Bailey (jakebailey) merged 3 commits into
Jake Bailey (jakebailey) merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
tests/baselines/reference/erasableSyntaxOnlyDeclaration.errors.txt
Outdated
Nathan Shively-Sanders (sandersn)
approved these changes
Feb 18, 2025
Copy link
Copy Markdown
Member
Author
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-5.8 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Starting jobs; this comment will be updated as builds start and complete.
|
Sorry, something went wrong.
TypeScript Bot (typescript-bot)
pushed a commit
that referenced
this pull request
Feb 20, 2025
Copy link
Copy Markdown
Contributor
|
Hey, Jake Bailey (@jakebailey)! I've created #61237 for you. |
Sorry, something went wrong.
Daniel Rosenwasser (DanielRosenwasser)
pushed a commit
that referenced
this pull request
Feb 26, 2025
…e-5.8 (#61237) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot that export default and export = are the same node, just with an extra marker. Oops.
See #61175 (comment).