| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
This PR deprecates several legacy module formats (amd, umd, system, none) and the classic module resolution strategy, while changing the default moduleResolution for ES module formats from classic to bundler. These deprecated options will stop functioning in TypeScript 7.0.
Copilot reviewed 299 out of 1932 changed files in this pull request and generated no comments.
Show a summary per file| File | Description |
|---|---|
| Multiple *.errors.txt files | Added deprecation warnings for deprecated module formats and classic resolution |
| Multiple *.js baseline files | Removed AMD/UMD/System wrapper code, showing CommonJS output instead |
| Multiple *.types baseline files | Updated type information reflecting bundler resolution |
| Multiple *.symbols baseline files | Updated import paths from bare specifiers to relative paths |
| Config baseline files | Updated error messages to remove deprecated options from valid choices |
Sorry, something went wrong.
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up. |
Sorry, something went wrong.
|
TypeScript Bot (@typescript-bot) user test this |
Sorry, something went wrong.
|
Starting jobs; this comment will be updated as builds start and complete.
|
Sorry, something went wrong.
|
Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so: {
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/166375/artifacts?artifactName=tgz&fileId=C423F954FA7ABC3DA7B47D6984471C48D3D6C4A6BEF4E66FD691EC5F8B596AE802&fileName=/typescript-6.0.0-insiders.20251024.tgz"
}
}
and then running npm install. There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@6.0.0-pr-62669-3".; |
Sorry, something went wrong.
|
Jake Bailey (@jakebailey) Here are the results of running the user tests with tsc comparing main and refs/pull/62669/merge: There were infrastructure failures potentially unrelated to your change:
Otherwise... Everything looks good! |
Sorry, something went wrong.
There was a problem hiding this comment.
🫡
Sorry, something went wrong.
|
I am going to go ahead and port this into tsgo-port since none of these things are implemented in Corsa anyway. It should light up a bunch of new tests and make other diffs go away. TypeScript Bot (@typescript-bot) cherry-pick into tsgo-port |
Sorry, something went wrong.
|
Starting jobs; this comment will be updated as builds start and complete.
|
Sorry, something went wrong.
|
Jake Bailey (@jakebailey) Here are the results of running the top 800 repos with tsc comparing main and refs/pull/62669/merge: Something interesting changed - please have a look. Detailsmicrosoft/azuredatastudio43 of 67 projects failed to build with the old tsc and were ignored src/tsconfig.vscode-proposed-dts.json
microsoft/vscode12 of 63 projects failed to build with the old tsc and were ignored src/tsconfig.vscode-proposed-dts.json
voideditor/void25 of 58 projects failed to build with the old tsc and were ignored src/tsconfig.vscode-proposed-dts.json
|
Sorry, something went wrong.
|
Hey, Andrew Branch (@andrewbranch)! I was unable to cherry-pick this PR. Check the logs at: https://github.com/microsoft/TypeScript/actions/runs/18793106856 |
Sorry, something went wrong.
|
Interesting; I'll try to see what Azure Data Studio and VS Code are trying to do with --module none. We are deprecating it because its behavior is inconsistent and weird in Strada, but it could potentially be useful to bring back as something coherent if a strong case for it emerges. |
Sorry, something went wrong.
…n classic`; change defaults (microsoft#62669)
| Back | FazBrowse Home | New Git URL |
This leaves the module default as-is for now, but changes the computed moduleResolution default for the es series to be bundler. Deprecated module modes still default to classic.
I went through compiler tests and fourslash tests and changed them to use non-deprecated options if they weren’t intending to test the newly deprecated options. That will allow them to come into typescript-go for better coverage.
Closes #62199
Closes #62206