Update module default value in tsconfigRules - #3608
Open
Jon Koops (jonkoops) wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Jon Koops (jonkoops)
force-pushed
the
fix/update-module-default-value
branch
from
0c5a837 to
16f13b4
Compare
July 9, 2026 08:00
Signed-off-by: Jon Koops <jonkoops@gmail.com>
Jon Koops (jonkoops)
force-pushed
the
fix/update-module-default-value
branch
from
16f13b4 to
a7a2f25
Compare
July 9, 2026 08:06
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented default value for the module compiler option is outdated since TypeScript 6.0.
In TypeScript 5.x, the default was "CommonJS if target is ES5; ES2015 otherwise". In TypeScript 6.0, the target default changed to es2025 and the module computation was updated to:
The relevant computation logic in the compiler:
https://github.com/microsoft/TypeScript/blob/b24015058ae060de249acf5ea09e15dd92a55587/src/compiler/utilities.ts#L9055-L9076
Fixes microsoft/TypeScript#63330
Relates to microsoft/TypeScript#63392