| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping Sheetal Nandi (@sheetalkamat), Matt Bierner (@mjbvz), and Joaquin Jares (@joj) for you. Feel free to loop in other consumers/maintainers if necessary. |
Sorry, something went wrong.
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up. |
Sorry, something went wrong.
|
TypeScript Bot (@typescript-bot) test it |
Sorry, something went wrong.
|
Starting jobs; this comment will be updated as builds start and complete.
|
Sorry, something went wrong.
|
Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so: {
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/167004/artifacts?artifactName=tgz&fileId=EF769C50B14300245DEC1C19259502941AC541B769FEE5839095048E28F6936902&fileName=/typescript-6.0.0-insiders.20260130.tgz"
}
}
and then running npm install. There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@6.0.0-pr-63067-4".; |
Sorry, something went wrong.
| computeValue: (compilerOptions): ModuleKind => { | ||
| return typeof compilerOptions.module === "number" ? | ||
| compilerOptions.module : | ||
| _computedOptions.target.computeValue(compilerOptions) >= ScriptTarget.ES2015 ? ModuleKind.ES2015 : ModuleKind.CommonJS; |
There was a problem hiding this comment.
In a later PR, I will update this to set other ModuleKinds based on the target.
Sorry, something went wrong.
|
Jake Bailey (@jakebailey) Here are the results of running the user tests with tsc comparing main and refs/pull/63067/merge: There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Detailsacorn/mnt/ts_downloads/_/m/acorn/tsconfig.json
adonis-framework/mnt/ts_downloads/_/m/adonis-framework/tsconfig.json
ajv/mnt/ts_downloads/_/m/ajv/tsconfig.json
antd/mnt/ts_downloads/_/m/antd/tsconfig.json
assert/mnt/ts_downloads/_/m/assert/tsconfig.json
async/mnt/ts_downloads/_/m/async/tsconfig.json
axios/mnt/ts_downloads/_/m/axios/tsconfig.json
bcryptjs/mnt/ts_downloads/_/m/bcryptjs/tsconfig.json
bignumber.js/mnt/ts_downloads/_/m/bignumber.js/tsconfig.json
bluebird/mnt/ts_downloads/_/m/bluebird/tsconfig.json
clear-require/mnt/ts_downloads/_/m/clear-require/tsconfig.json
clone/mnt/ts_downloads/_/m/clone/tsconfig.json
content-disposition/mnt/ts_downloads/_/m/content-disposition/tsconfig.json
debug/mnt/ts_downloads/_/m/debug/tsconfig.json
discord.js/mnt/ts_downloads/_/m/discord.js/tsconfig.json
electron/mnt/ts_downloads/_/m/electron/tsconfig.json
eventemitter2/mnt/ts_downloads/_/m/eventemitter2/tsconfig.json
eventemitter3/mnt/ts_downloads/_/m/eventemitter3/tsconfig.json
firebase/mnt/ts_downloads/_/m/firebase/tsconfig.json
follow-redirects/mnt/ts_downloads/_/m/follow-redirects/tsconfig.json
fp-tstsconfig.json
tsconfig.build-es6.json
examples/tsconfig.json
dtslint/tsconfig.json
graceful-fs/mnt/ts_downloads/_/m/graceful-fs/tsconfig.json
immutable/mnt/ts_downloads/_/m/immutable/tsconfig.json
isobject/mnt/ts_downloads/_/m/isobject/tsconfig.json
jimp/mnt/ts_downloads/_/m/jimp/tsconfig.json
jsonschema/mnt/ts_downloads/_/m/jsonschema/tsconfig.json
keycode/mnt/ts_downloads/_/m/keycode/tsconfig.json
localforage/mnt/ts_downloads/_/m/localforage/tsconfig.json
lodash/mnt/ts_downloads/_/m/lodash/tsconfig.json
log4js/mnt/ts_downloads/_/m/log4js/tsconfig.json
minimatch/mnt/ts_downloads/_/m/minimatch/tsconfig.json
mobx/mnt/ts_downloads/_/m/mobx/tsconfig.json
moment/mnt/ts_downloads/_/m/moment/tsconfig.json
mqtt/mnt/ts_downloads/_/m/mqtt/tsconfig.json
npmlog/mnt/ts_downloads/_/m/npmlog/tsconfig.json
octokit-rest/mnt/ts_downloads/_/m/octokit-rest/tsconfig.json
portfinder/mnt/ts_downloads/_/m/portfinder/tsconfig.json
protobufjs/mnt/ts_downloads/_/m/protobufjs/tsconfig.json
redux/mnt/ts_downloads/_/m/redux/tsconfig.json
reselect/mnt/ts_downloads/_/m/reselect/tsconfig.json
rxjs/mnt/ts_downloads/_/m/rxjs/tsconfig.json
should/mnt/ts_downloads/_/m/should/tsconfig.json
sift/mnt/ts_downloads/_/m/sift/tsconfig.json
soap/mnt/ts_downloads/_/m/soap/tsconfig.json
sugar/mnt/ts_downloads/_/m/sugar/tsconfig.json
tslint/mnt/ts_downloads/_/m/tslint/tsconfig.json
uglify-js/mnt/ts_downloads/_/m/uglify-js/tsconfig.json
url-search-params/mnt/ts_downloads/_/m/url-search-params/tsconfig.json
util/mnt/ts_downloads/_/m/util/tsconfig.json
vue/mnt/ts_downloads/_/m/vue/tsconfig.json
vuex/mnt/ts_downloads/_/m/vuex/tsconfig.json
webpacktsconfig.hot.json
xlsx/mnt/ts_downloads/_/m/xlsx/tsconfig.json
xpath/mnt/ts_downloads/_/m/xpath/tsconfig.json
|
Sorry, something went wrong.
|
Jake Bailey (@jakebailey) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/63067/merge: Something interesting changed - please have a look. Detailsapitable/apitable14 of 15 projects failed to build with the old tsc and were ignored packages/databus-client/tsconfig.json
basarat/typescript-book10 of 15 projects failed to build with the old tsc and were ignored code/async-await/es5/tsconfig.json
compiler-explorer/compiler-explorer4 of 7 projects failed to build with the old tsc and were ignored tsconfig.frontend.tests.json
faker-js/faker1 of 2 projects failed to build with the old tsc and were ignored cypress/tsconfig.json
radix-ui/primitives64 of 68 projects failed to build with the old tsc and were ignored cypress/tsconfig.json
|
Sorry, something went wrong.
There was a problem hiding this comment.
Overall LGTM, I am OK with any proposed name for the "current" target version
Sorry, something went wrong.
Sorry, something went wrong.
|
Starting jobs; this comment will be updated as builds start and complete.
|
Sorry, something went wrong.
| ); | ||
| const reportDiagnostic = ts.createDiagnosticReporter(system); | ||
| const parsedConfig = ts.parseConfigFileWithSystem("tsconfig.json", {}, /*extendedConfigCache*/ undefined, /*watchOptionsToExtend*/ undefined, system, reportDiagnostic)!; | ||
| const parsedConfig = ts.parseConfigFileWithSystem("tsconfig.json", { target: ts.ScriptTarget.ES5, module: ts.ModuleKind.AMD }, /*extendedConfigCache*/ undefined, /*watchOptionsToExtend*/ undefined, system, reportDiagnostic)!; |
There was a problem hiding this comment.
I see you're still using ES5 here - are you just doing this to avoid churning baselines?
Sorry, something went wrong.
There was a problem hiding this comment.
Ryan asked me about this one too. Yes, this is to avoid churning baselines.
Sorry, something went wrong.
| compilerOptions: { | ||
| incremental: true, | ||
| target: "es5", | ||
| target: "es2015", |
There was a problem hiding this comment.
But so why is this one ES2015?
Sorry, something went wrong.
There was a problem hiding this comment.
I changed most tests that broke to es2015 first, and then flipped things back. In this case I'm sure I did it to avoid a deprecation error that messes up the incremental test.
Sorry, something went wrong.
|
Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready. Everything looks the same! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
target now defaults to ScriptTarget.LatestStandard, which is an alias to the most recent standardized ES version, currently ES2024 (until we add ES2025).
target=ES5 is now deprecated.
#63066 got most tests ready, but a few unit tests still needed to be updated. Individual commits may be a better way to review this.
Fixes #62196
Fixes #62198