Allow method return types to end with a digit - #199
Allow method return types to end with a digit#199Marin Marinov (gcnew) wants to merge 2 commits into
Conversation
Sorry, something went wrong.
|
Hi Marin Marinov (@gcnew), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Sorry, something went wrong.
|
Marin Marinov (@gcnew), Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Sorry, something went wrong.
| ^^public ^^testMethodReturnType12(): number | string [] { ^^return } | ||
| ^^public ^^testMethodReturnType13(): [number, number] | string [] { ^^return [""] } | ||
| } No newline at end of file | ||
| ^^public ^^testMethodReturnType14(): EndsWithDigit1 { ^^return 123 } |
There was a problem hiding this comment.
Can you add a check to scope of 123 and after 123, like --
^^return ^^123 ^^}
Sorry, something went wrong.
There was a problem hiding this comment.
Done.
Sorry, something went wrong.
|
Sorry for the delay, this should be fixed now by #257 |
Sorry, something went wrong.
Syntax coloring fails if method return type ends with a digit. This pull request allows digits to be the last character in type-annotation.end regular expression.
Fixes microsoft/TypeScript#9444 and should be in line with the to-be-added numeric literal types microsoft/TypeScript#9407.