FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Rewrite and fixes for lot of grammar issues by sheetalkamat · Pull Request #257 · microsoft/TypeScript-TmLanguage · GitHub

Rewrite and fixes for lot of grammar issues - #257

Merged
Sheetal Nandi (sheetalkamat) merged 78 commits into
masterfrom
modifyExistingGrammar
Sep 16, 2016
Merged

Rewrite and fixes for lot of grammar issues#257
Sheetal Nandi (sheetalkamat) merged 78 commits into
masterfrom
modifyExistingGrammar

Conversation

Copy link
Copy Markdown
Member

No description provided.

Note jsx attribute value is colored as string with this and its a TODO
…d object type's field declaration's type annotation

Copy link
Copy Markdown

Nice work! Looking forward to testing it out.

Copy link
Copy Markdown

Should it also effect on this?
microsoft/vscode#11398

And when will it be available?

Copy link
Copy Markdown
Contributor

And when will it be available?

we should have this in a vscode extension for users to try it out next week. if every thing looks good, should be available in vscode's subsequent releases.

Copy link
Copy Markdown

Mohamed Hegazy (@mhegazy)

Thanks a lot for the hard work! Can you give an overview of the most important grammar issues that get fixed in this PR?

Copy link
Copy Markdown
Contributor

there are some 120 issues that are fixed by this change (linked above). it is almost a rewrite at this point. give it a try and let us know if there are other issues we are not aware of.

Copy link
Copy Markdown

give it a try and let us know if there are other issues we are not aware of.

So it is not available yet right? What will be need to it out, just use vscode insiders?

Copy link
Copy Markdown
Member Author

Renamed in favour of (@whitecolor) the issue you mentioned seems to be fixed.

Copy link
Copy Markdown

Sheetal Nandi (@sheetalkamat) is this going to be merged soon? Can i test it already?
Thanks

Copy link
Copy Markdown
Contributor

farfromrefuge (@farfromrefug) you can find these changes in the VSCode extension: https://marketplace.visualstudio.com/items?itemName=ms-vscode.typescript-javascript-grammar

Copy link
Copy Markdown

Thanks Mohamed Hegazy (@mhegazy) will test it right away!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL