chore: Main to Dev downMerge by Vamshi-Microsoft · Pull Request #653 · microsoft/content-processing-solution-accelerator · GitHub

Purpose

This pull request introduces several infrastructure changes to how container images are configured and deployed, as well as updates to documentation and code ownership. The main focus is on removing parameterized container image settings in favor of hardcoded sample images, updating container registry access, and improving deployment instructions.

Infrastructure changes:

The Bicep and ARM templates (infra/main.bicep, infra/main.json) now use the public Microsoft "helloworld" container image (mcr.microsoft.com/azuredocs/containerapps-helloworld:latest) for all container apps, replacing the previous use of parameters for custom registry endpoints and image tags. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
Container registry access is now explicitly set in the deployment modules, referencing the output of the container registry and its reader identity, instead of being null. This clarifies which registry is used and how identities are assigned. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
Parameters for containerRegistryEndpoint and imageTag have been removed from the templates, simplifying the deployment configuration. [1] [2]
Role assignment for the managed identity as "Owner" has been removed from the AI Services module, likely to reduce unnecessary permissions. [1] [2]

Documentation and configuration:

The deployment guide (docs/DeploymentGuide.md) now instructs users to manually run ACR build/push and post-deployment scripts, reflecting the changes in automation.
The azure.yaml postprovision hook is now empty, indicating that post-provisioning steps are no longer automated via this hook.
The .github/CODEOWNERS file has been updated to correct some owner usernames.

These changes collectively shift the deployment process toward using sample images and manual post-deployment steps, while clarifying registry access and permissions.

Does this introduce a breaking change?

Yes
No

Golden Path Validation

I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

...

Other Information

Replace @Vinay-Microsoft -> @VinaySh-Microsoft and @Prajwal-Microsoft -> @Prajwal1-Microsoft

feat: Developed scripts and Implement ACR deployment

chore: Update acr script to handle WAF deployment

docs: Update deployment script and azure.yaml to run script in proper sequence

Pull request overview

This PR updates the deployment/infrastructure posture to deploy Container Apps with a fixed public “hello world” image by default (removing prior image parameterization), tightens/clarifies registry wiring and role assignments, and shifts post-provision steps from automated azd hooks to manual scripts with updated documentation.

Changes:

Hardcode Container Apps images to mcr.microsoft.com/azuredocs/containerapps-helloworld:latest and remove containerRegistryEndpoint / imageTag parameters from Bicep/ARM + parameter files.
Add new ACR build/push helper scripts (bash + PowerShell) to build images in ACR and update Container Apps to use them post-deploy.
Remove azd postprovision automation and update deployment instructions and CODEOWNERS.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
infra/scripts/acr_build_push.sh	Adds bash script to ACR-build images and update Container Apps post-deploy.
infra/scripts/acr_build_push.ps1	Adds PowerShell equivalent of the ACR build/push + app update flow.
infra/modules/container-registry.bicep	Adjusts default publicNetworkAccess behavior based on private networking toggle.
infra/main.waf.parameters.json	Removes registry/image parameter entries from WAF parameters file.
infra/main.parameters.json	Removes registry/image parameter entries from default parameters file.
infra/main.json	Removes containerRegistryEndpoint / imageTag parameters; hardcodes hello world images; updates registry identity wiring.
infra/main.bicep	Removes containerRegistryEndpoint / imageTag parameters; hardcodes hello world images; updates registry identity wiring.
infra/main_custom.bicep	Removes containerRegistryEndpoint / imageTag parameters (custom template flavor).
docs/DeploymentGuide.md	Updates post-deployment instructions to run ACR build/push and post-deploy scripts manually.
azure.yaml	Clears postprovision hook (no longer auto-running post-deploy steps).
.github/CODEOWNERS	Updates listed default code owners.

Comments suppressed due to low confidence (2)

infra/main.json:114

infra/main.json no longer defines the imageTag parameter, but the repo's CI workflow still passes imageTag=... to az deployment group create (see .github/workflows/deploy.yml:159). That deployment will fail with an unrecognized/unused parameter error unless the workflow is updated (or the parameter is reintroduced).
docs/DeploymentGuide.md:339
This section still says schema registration happens automatically via the azd up postprovision hook, but azure.yaml now sets hooks.postprovision to {} and Step 5.1 instructs running post_deployment.* manually. The current text is contradictory and will mislead users following the guide.

### 5.2 Schema Registration (Automatic)

 > Want to customize the schemas for your own documents? [Learn more about adding your own schemas here.](./CustomizeSchemaData.md)

Schema registration happens **automatically** as part of the `azd up` post-provisioning hook — no manual steps required. After infrastructure is deployed, the hook:

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Rafi-Mohammad-69 and others added 21 commits June 29, 2026 13:44

chore: update CODEOWNERS handles

8d7c18f

Replace @Vinay-Microsoft -> @VinaySh-Microsoft and @Prajwal-Microsoft -> @Prajwal1-Microsoft

chore: update CODEOWNERS handles

7f519a2

chore: Dev to Main

d99e090

Create script to build and push image

d4264fd

revert unnecessary change

e9422c0

Update the script

e43b016

Revert unnecessary changes from main.parametres.json

318391b

bicep build changes

9f9ae02

Update deployment guide

98dac8c

update scripts

3f69b91

resolve copilot comment

82a7711

Update image

60197dc

Update bicep build version

201fc45

Merge pull request #648 from chaudhariniraj/psl-add-acr

5614b5f

feat: Developed scripts and Implement ACR deployment

Update acr script to handle WAF deployment

b86fbae

resolve copilot comment

dc9941e

Update container registry code

113ef2a

Resolve Copilot comment

88918f8

Merge pull request #649 from chaudhariniraj/psl-add-acr

591debf

chore: Update acr script to handle WAF deployment

Update deployment script and azure.yaml

5e09c5c

Merge pull request #650 from chaudhariniraj/psl-add-acr

deab07d

docs: Update deployment script and azure.yaml to run script in proper sequence

Copilot AI review requested due to automatic review settings July 14, 2026 13:41

Vamshi-Microsoft requested review from Avijit-Microsoft, Roopan-Microsoft, Anish Arora (aniaroramsft), dgp10801, nchandhi and Todd Herman (toherman-msft) as code owners July 14, 2026 13:41

Copilot started reviewing on behalf of Vamshi-Microsoft July 14, 2026 13:42 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread infra/scripts/acr_build_push.ps1

Comment thread infra/scripts/acr_build_push.ps1

Comment thread infra/scripts/acr_build_push.sh

Vamshi-Microsoft changed the title chore: Dev to Main Merge chore: Main to Dev downMerge Jul 14, 2026

Roopan-Microsoft approved these changes Jul 14, 2026

View reviewed changes

Avijit-Microsoft approved these changes Jul 14, 2026

View reviewed changes

Avijit-Microsoft merged commit 796d3a0 into dev Jul 14, 2026
22 checks passed

Prajwal-Microsoft had a problem deploying to production July 16, 2026 02:14 — with GitHub Actions Failure

chore: Main to Dev downMerge by Vamshi-Microsoft · Pull Request #653 · microsoft/content-processing-solution-accelerator · GitHub

chore: Main to Dev downMerge - #653

chore: Main to Dev downMerge#653
Avijit-Microsoft merged 21 commits into
devfrom
main

Vamshi-Microsoft commented Jul 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch had an error being deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

chore: Main to Dev downMerge by Vamshi-Microsoft · Pull Request #653 · microsoft/content-processing-solution-accelerator · GitHub

chore: Main to Dev downMerge - #653

chore: Main to Dev downMerge#653Avijit-Microsoft merged 21 commits intodevmicrosoft/content-processing-solution-accelerator:devfrom mainmicrosoft/content-processing-solution-accelerator:mainCopy head branch name to clipboard

Conversation

Vamshi-Microsoft commented Jul 14, 2026

Purpose

Does this introduce a breaking change?

Golden Path Validation

Deployment Validation

What to Check

Other Information

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch had an error being deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

chore: Main to Dev downMerge#653
Avijit-Microsoft merged 21 commits into
devfrom
main