chore: roll to 1.62.0-alpha-1784109367000 - #3134
Merged
Simon Knott (Skn0tt) merged 5 commits intoJul 17, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Port the public API changes introduced upstream since 1.61 and adapt the client to the protocol-level timeout metadata field. - feat(routeFromHar): interceptAPIRequests option - feat(webauthn): credentials option on BrowserContext.storageState - feat(locator): Locator.wait_for_function() - feat(actions): scroll option to opt out of autoscroll - feat(screenshot): webp output format - adapt channel sends to send timeout as protocol-level metadata AbortSignal is intentionally not ported to Python. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3813c827-3dfc-44a4-9433-cae8c2919c95
Simon Knott (Skn0tt)
force-pushed
the
skn0tt-roll-1-62-0-alpha-1784109367000
branch
from
75bc6eb to
9947444
Compare
July 15, 2026 14:39
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3813c827-3dfc-44a4-9433-cae8c2919c95
Simon Knott (Skn0tt)
marked this pull request as ready for review
July 15, 2026 15:35
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3813c827-3dfc-44a4-9433-cae8c2919c95
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3813c827-3dfc-44a4-9433-cae8c2919c95
Dmitry Gozman (dgozman)
approved these changes
Jul 16, 2026
Comment thread
playwright/_impl/_browser_context.py
| finally: | ||
| if len(self._routes) == 0: | ||
| asyncio.create_task( | ||
| create_task_and_ignore_exception( |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Why this change? Can you link to the upstream counterpart?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Sorry, something went wrong.
Comment thread
playwright/_impl/_network.py
Outdated
| raise Error("Already connected to the server") | ||
| self._connected = True | ||
| asyncio.create_task( | ||
| create_task_and_ignore_exception( |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Same question here - why is this suddenly ignoring exception?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Sorry, something went wrong.
Comment thread
playwright/_impl/_page.py
Outdated
| result = await result | ||
| await self._channel.send( | ||
| "resolve", None, dict(result=serialize_argument(result)) | ||
| create_task_and_ignore_exception( |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
It looks like most of these create_task_and_ignore_exception calls are wrapping channel.send. Perhaps create a channel.send_may_fail helper?
Sorry, something went wrong.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3813c827-3dfc-44a4-9433-cae8c2919c95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbortSignal is intentionally not ported to Python, I might connect __abort__ to task cancellation. I'll do it in a followup because it's possibly breaking.