fix(asyncio): abort protocol calls on task cancellation - #3144
Merged
Simon Knott (Skn0tt) merged 1 commit intoJul 17, 2026
Merged
fix(asyncio): abort protocol calls on task cancellation#3144Simon Knott (Skn0tt) merged 1 commit into
Simon Knott (Skn0tt) merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Complete cancellation propagation now that the driver supports protocol aborts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c3c85ae6-2b5f-4f50-9158-ce3c886f750a
Dmitry Gozman (dgozman)
approved these changes
Jul 17, 2026
This was referenced Aug 4, 2026
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the follow-up left in #3134 and finishes the cancellation behaviour introduced in #1236.
#1236 made cancelled asyncio tasks cancel their local protocol callback. The stated intention was to propagate cancellation to the protocol call, but the driver operation kept running because the protocol couldn't abort it yet.
With __abort__, cancelling a task now stops the driver operation and waits for its protocol response before re-raising CancelledError. This follows asyncio's guidance to propagate cancellation after cleanup completes.
This is an observable behaviour change: previously, a cancelled action could still happen later. Users who intentionally want an operation to outlive its caller can run it in a separate task and protect it with asyncio.shield().
The regression test blocks a click, cancels it, unblocks the button, and verifies that it stays unclicked.