chore(driver): roll to 1.62.0 - #3160
Conversation
Sorry, something went wrong.
Simon Knott (Skn0tt)
left a comment
There was a problem hiding this comment.
I believe this is missing the screencast ack, see microsoft/playwright@bc97a13.
Sorry, something went wrong.
roll the driver to `1.62.0` and regenerate the sync and async APIs from the `v1.62.0` documentation upstream removed the `routeFromHar` `interceptAPIRequests` option before `1.62.0`, so drop `intercept_api_requests`, `HarRouter.add_api_request_route`, and their tests Firefox `153` fixes <microsoft/playwright#38919>, so use the context locale expectation for every browser acknowledge each screencast frame after its callback finishes so the driver can apply backpressure and deliver the next frame
| ) | ||
| finally: | ||
| if result is not None and hasattr(result, "__await__"): | ||
| self._page._loop.create_task( |
There was a problem hiding this comment.
this task should be somehow returned into the page._channel.on() caller in L54, otherwise exceptions in onFrame customer code are silently swallowed. This isn't a problem in Node.js land because there's the unhandled rejection concept, this doesn't exist in Python though.
Otherwise this is the same as I came up with in #3161, which is a good sign. Let's figure out why these Chromium tests are hanging.
Sorry, something went wrong.
|
The failing CI seems to be related to microsoft/playwright#41303 and page.close() hanging, i'm looking into it. Edit: See #3161 (comment). |
Sorry, something went wrong.
Rolls the driver to 1.62.0 and regenerates the sync and async APIs from the v1.62.0 documentation.
Upstream removed the routeFromHar interceptAPIRequests option before 1.62.0 in microsoft/playwright#41964 and microsoft/playwright#41965. This drops intercept_api_requests, the HarRouter.add_api_request_route helper, the routeAPIRequestsFromHar and unrouteAPIRequestsFromHar calls, and their tests. The tests asserting API requests are not served from HAR by default remain.
Firefox 153 fixes microsoft/playwright#38919, so the worker locale test now uses the context locale expectation for every browser.
The 1.62.0 driver requires each screencastFrame event to be acknowledged after its callback finishes. The Python client now sends screencastFrameAck after sync callbacks and awaited async callbacks, preserving backpressure.
Validation: