chore: roll Playwright to 1.62.0 - #3161
Merged
Devin Rousso (dcrousso) merged 2 commits intoJul 31, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copilot-Session: 93944f7c-c521-4248-936d-d4240acd29fc
Copy link
Copy Markdown
Member
Author
|
The failing CI seems to be related to microsoft/playwright#41303 and page.close() hanging, i'm looking into it. |
Sorry, something went wrong.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 93944f7c-c521-4248-936d-d4240acd29fc
Copy link
Copy Markdown
Member
Author
|
5aee361 should fix it by moving our fixtures here closer to what upstream does, and relying on context.close() for cleanup solely instead of also having page.close() on page fixture teardown. This only affects this repo and not our customers, the playwright-pytest integration already has this behaviour. |
Sorry, something went wrong.
Devin Rousso (dcrousso)
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3145